Changeset 3848

Timestamp:

06/06/2006 04:50:41 AM (19 years ago)

Author:

ryan

Message:

Deprecate list_authors(). Clean up wp_list_authors().

Location:

trunk/wp-includes

Files:

• deprecated.php (modified) (1 diff)
• template-functions-author.php (modified) (1 diff)

trunk/wp-includes/deprecated.php

@@ -457 +457 @@
     wp_print_script( 'wp_tiny_mce' );
 }
+
+function list_authors($optioncount = false, $exclude_admin = true, $show_fullname = false, $hide_empty = true, $feed = '', $feed_image = '') {
+    $args = compact('optioncount', 'exclude_admin', 'show_fullname', 'hide_empty', 'feed', 'feed_image');
+    return wp_list_authors($args);
+}
+
 ?>

trunk/wp-includes/template-functions-author.php

@@ -157 +157 @@
 
 function wp_list_authors($args = '') {
-    parse_str($args, $r);
-
-    if ( !isset($r['optioncount']) )
-        $r['optioncount'] = false;
-    if ( !isset($r['exclude_admin']) )
-        $r['exclude_admin'] = true;
-    if ( !isset($r['show_fullname']) )
-        $r['show_fullname'] = false;
-    if ( !isset($r['hide_empty']) )
-        $r['hide_empty'] = true;
-    if ( !isset($r['feed']) )
-        $r['feed'] = '';
-    if ( !isset($r['feed_image']) )
-        $r['feed_image'] = '';
-
-    list_authors($r['optioncount'], $r['exclude_admin'], $r['show_fullname'], $r['hide_empty'], $r['feed'], $r['feed_image']);
-}
-
-function list_authors($optioncount = false, $exclude_admin = true, $show_fullname = false, $hide_empty = true, $feed = '', $feed_image = '') {
+    if ( is_array($args) )
+        $r = &$args;
+    else
+        parse_str($args, $r);
+
+    $defaults = array('optioncount' => false, 'exclude_admin' => true, 'show_fullname' => false, 'hide_empty' => true,
+        'feed' => '', 'feed_image' => '');
+    $r = array_merge($defaults, $r);
+    extract($r);
+
     global $wpdb;
+    // TODO:  Move select to get_authors().
     $query = "SELECT ID, user_nicename from $wpdb->users " . ($exclude_admin ? "WHERE user_login <> 'admin' " : '') . "ORDER BY display_name";
     $authors = $wpdb->get_results($query);