Changeset 38511

Timestamp:

09/02/2016 04:16:00 AM (8 years ago)

Author:

jorbin

Message:

Formatting: Allow KSES custom elements with hyphens

The W3C Custom Elements spec (​http://www.w3.org/TR/custom-elements/#concepts) allows you to use your own custom DOM elements/tags. One of the main requirements is that the tag name "must contain a U+002D HYPHEN-MINUS character". This adjusts KSES to allow it.

Fixes #34105.
Props batmoo.

Location:

trunk

Files:

• src/wp-includes/kses.php (modified) (1 diff)
• tests/phpunit/tests/kses.php (modified) (1 diff)

trunk/src/wp-includes/kses.php

@@ -782 +782 @@
     // Allow HTML comments
 
-    if (!preg_match('%^<\s*(/\s*)?([a-zA-Z0-9]+)([^>]*)>?$%', $string, $matches))
+    if (!preg_match('%^<\s*(/\s*)?([a-zA-Z0-9-]+)([^>]*)>?$%', $string, $matches))
         return '';
     // It's seriously malformed

trunk/tests/phpunit/tests/kses.php

@@ -361 +361 @@
     }
 
+    function test_hyphenated_tag() {
+        $string = "<hyphenated-tag attribute=\"value\" otherattribute=\"value2\">Alot of hyphens.</hyphenated-tag>";
+        $custom_tags = array(
+            'hyphenated-tag' => array(
+                'attribute' => true,
+            ),
+        );
+        $expect_stripped_string = 'Alot of hyphens.';
+
+        $expect_valid_string = "<hyphenated-tag attribute=\"value\">Alot of hyphens.</hyphenated-tag>";
+        $this->assertEquals( $expect_stripped_string, wp_kses_post( $string ) );
+        $this->assertEquals( $expect_valid_string, wp_kses( $string, $custom_tags ) );
+    }
+
     /**
      * @ticket 26290