Changeset 38523 for trunk/tests/phpunit/tests/post/listPages.php

Timestamp:

09/06/2016 09:05:45 AM (8 years ago)

Author:

peterwilsoncc

Message:

Menus: Add white space option to wp_nav_menu() and wp_list_pages().

Adds an item_spacing option to the arguments array for the functions wp_nav_menu(), wp_list_pages(), and wp_page_menu(). item_spacing is a boolean accepting either preserve or discard.

Previously, certain CSS choices could result in a site's layout changing if wp_nav_menu() fell back to the default wp_list_pages() due to differences in the whitespace within the HTML. The new argument ensures a function outputs consistant HTML while maintaining backward compatibility.

Fixes #35206.

File:

• trunk/tests/phpunit/tests/post/listPages.php (modified) (2 diffs)

trunk/tests/phpunit/tests/post/listPages.php

@@ -18 +18 @@
         'link_after' => '',
         'walker' => '',
+        'item_spacing' => 'preserve',
         'include'      => '',
         'post_type'    => 'page',
@@ -343 +344 @@
         $this->AssertEquals( $expected['exclude'], $actual );
     }
+
+    function test_wp_list_pages_discarded_whitespace() {
+        $args = array(
+            'echo' => false,
+            'item_spacing' => 'discard',
+        );
+        $expected['default'] = '<li class="pagenav">Pages<ul><li class="page_item page-item-1 page_item_has_children"><a href="' . get_permalink( 1 ) . '">Parent 1</a><ul class=\'children\'><li class="page_item page-item-4"><a href="' . get_permalink( 4 ) . '">Child 1</a></li><li class="page_item page-item-5"><a href="' . get_permalink( 5 ) . '">Child 2</a></li><li class="page_item page-item-6"><a href="' . get_permalink( 6 ) . '">Child 3</a></li></ul></li><li class="page_item page-item-2 page_item_has_children"><a href="' . get_permalink( 2 ) . '">Parent 2</a><ul class=\'children\'><li class="page_item page-item-7"><a href="' . get_permalink( 7 ) . '">Child 1</a></li><li class="page_item page-item-8"><a href="' . get_permalink( 8 ) . '">Child 2</a></li><li class="page_item page-item-9"><a href="' . get_permalink( 9 ) . '">Child 3</a></li></ul></li><li class="page_item page-item-3 page_item_has_children"><a href="' . get_permalink( 3 ) . '">Parent 3</a><ul class=\'children\'><li class="page_item page-item-10"><a href="' . get_permalink( 10 ) . '">Child 1</a></li><li class="page_item page-item-11"><a href="' . get_permalink( 11 ) . '">Child 2</a></li><li class="page_item page-item-12"><a href="' . get_permalink( 12 ) . '">Child 3</a></li></ul></li></ul></li>';
+        $actual = wp_list_pages( $args );
+        $this->AssertEquals( $expected['default'], $actual );
+    }
 }