Changeset 38582

Timestamp:

09/09/2016 12:33:52 AM (8 years ago)

Author:

pento

Message:

Tests: Use add_filter() when it's available.

The tests_add_filter() helper function directly manipulates the $wp_filter global, instead of using add_filter(). We can use add_filter() when it's available, and fall back to manipulating $wp_filter when it isn't, relying on the $wp_filter bootstrap code at the top of plugin.php to handle conversion.

Props boonebgorges, dd32 and pento: WordPress Thought Leadership Triumvirate.
Fixes #17817.

File:

• trunk/tests/phpunit/includes/functions.php (modified) (1 diff)

trunk/tests/phpunit/includes/functions.php

@@ -24 +24 @@
     global $wp_filter;
 
-    $idx = _test_filter_build_unique_id($tag, $function_to_add, $priority);
-    $wp_filter[$tag][$priority][$idx] = array('function' => $function_to_add, 'accepted_args' => $accepted_args);
+    if ( function_exists( 'add_filter' ) ) {
+        add_filter( $tag, $function_to_add, $priority, $accepted_args );
+    } else {
+        $idx = _test_filter_build_unique_id($tag, $function_to_add, $priority);
+        $wp_filter[$tag][$priority][$idx] = array('function' => $function_to_add, 'accepted_args' => $accepted_args);
+    }
     return true;
 }