Changeset 38616

Timestamp:

09/17/2016 03:38:40 PM (8 years ago)

Author:

afercia

Message:

Accessibility: Standardize the remove/delete/cancel links in the Menus screen and Publish meta boxes.

The submitdelete CSS class is used in various places across the admin for some
"red" action links. It is worth simplifying this rule for further improvements
related to color contrast.

• simplifies a non-standard styling for the "Remove/Cancel" links in the Menus screen
• underlines all the "Move to trash/Delete" red links in all the Publish meta boxes
• fixes CSS classes usage for all the Publish meta boxes primary buttons
• fixes broken layout for the old Link Manager publish meta box

Props karmatosed, hugobaeta, monikarao, afercia.
Fixes #37969, #37018. See #37448, #37138, #27314.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (2 diffs)
• css/edit.css (modified) (2 diffs)
• css/nav-menus.css (modified) (9 diffs)
• edit-form-comment.php (modified) (1 diff)
• includes/meta-boxes.php (modified) (3 diffs)
• nav-menus.php (modified) (2 diffs)

trunk/src/wp-admin/css/common.css

@@ -856 +856 @@
 #nav-menu-footer .menu-delete:hover {
     color: #f00;
-    text-decoration: none;
     border: none;
 }
@@ -876 +875 @@
 
 #delete-action {
+    float: left;
     line-height: 28px;
-    vertical-align: middle;
-    text-align: left;
-    float: left;
 }
 

trunk/src/wp-admin/css/edit.css

@@ -130 +130 @@
 }
 
-.submitbox .submitdelete {
-    text-decoration: none;
-    padding: 1px 2px;
-}
-
 body.post-new-php .submitbox .submitdelete {
     display: none;
-}
-
-/* @todo: do we really need this? word on the street is we don't and this
-stray rule may actually be compensated for elsewhere. */
-#normal-sortables .submitbox .submitdelete:hover {
-    color: #000;
-    background-color: #f00;
-    border-bottom-color: #f00;
 }
 
@@ -645 +632 @@
 }
 
+#linksubmitdiv .inside, /* Old Link Manager back-compat. */
 #poststuff #submitdiv .inside {
     margin: 0;

trunk/src/wp-admin/css/nav-menus.css

@@ -140 +140 @@
 
 /* Menu Container */
+
+/* @todo: responsive view. */
 #menu-management-liquid {
     float: left;
@@ -146 +148 @@
 }
 
+/* @todo: responsive view. */
 #menu-management {
     position: relative;
@@ -283 +286 @@
     margin: 0 0 10px;
     padding: 0;
-}
-
-.nav-menus-php .meta-sep,
-.nav-menus-php .submitdelete,
-.nav-menus-php .submitcancel {
-    display: block;
-    float: left;
-    margin: 6px 0;
-    line-height: 15px;
-}
-
-.meta-sep {
-    padding: 0 2px;
 }
 
@@ -481 +471 @@
     line-height: 20px;
     display: block;
+    /* @todo: responsive view. */
     margin-right: 13em;
 }
@@ -672 +663 @@
 .link-to-original {
     display: block;
-    margin: 0 0 10px;
+    margin: 0 0 15px;
     padding: 3px 5px 5px;
     border: 1px solid #ddd;
@@ -705 +696 @@
 .menu-item-actions {
     padding-top: 15px;
+    padding-bottom: 7px;
 }
 
@@ -714 +706 @@
 .nav-menus-php .major-publishing-actions {
     clear: both;
-    padding: 7px 0 6px;
+    padding: 10px 0;
+    line-height: 28px;
 }
 
@@ -726 +719 @@
 }
 
+/* Same as the Publish Meta Box #delete-action */
 .nav-menus-php .delete-action {
     float: left;
-    margin-top: 2px;
-}
-
-.nav-menus-php .submitbox .submitcancel {
-    border-bottom: 1px solid #0073aa;
-    padding: 1px 2px;
-    color: #0073aa;
-    text-decoration: none;
-}
-
-.nav-menus-php .submitbox .submitcancel:hover {
-    background: #0073aa;
-    color: #fff;
+    line-height: 28px;
 }
 
@@ -826 +808 @@
     }
 
-    .nav-menus-php .major-publishing-actions .publishing-action {
-        margin-top: 6px;
-    }
-
     .nav-menus-php .delete-action {
         font-size: 14px;
-        line-height: 50px;
-        margin-top: 12px;
+        line-height: 30px;
     }
 

trunk/src/wp-admin/edit-form-comment.php

@@ -163 +163 @@
 </div>
 <div id="publishing-action">
-<?php submit_button( __( 'Update' ), 'primary', 'save', false ); ?>
+<?php submit_button( __( 'Update' ), 'primary large', 'save', false ); ?>
 </div>
 <div class="clear"></div>

trunk/src/wp-admin/includes/meta-boxes.php

@@ -253 +253 @@
         if ( !empty($post->post_date_gmt) && time() < strtotime( $post->post_date_gmt . ' +0000' ) ) : ?>
         <input name="original_publish" type="hidden" id="original_publish" value="<?php esc_attr_e('Schedule') ?>" />
-        <?php submit_button( __( 'Schedule' ), 'primary button-large', 'publish', false ); ?>
+        <?php submit_button( __( 'Schedule' ), 'primary large', 'publish', false ); ?>
 <?php   else : ?>
         <input name="original_publish" type="hidden" id="original_publish" value="<?php esc_attr_e('Publish') ?>" />
-        <?php submit_button( __( 'Publish' ), 'primary button-large', 'publish', false ); ?>
+        <?php submit_button( __( 'Publish' ), 'primary large', 'publish', false ); ?>
 <?php   endif;
     else : ?>
         <input name="original_publish" type="hidden" id="original_publish" value="<?php esc_attr_e('Submit for Review') ?>" />
-        <?php submit_button( __( 'Submit for Review' ), 'primary button-large', 'publish', false ); ?>
+        <?php submit_button( __( 'Submit for Review' ), 'primary large', 'publish', false ); ?>
 <?php
     endif;
@@ -335 +335 @@
         <span class="spinner"></span>
         <input name="original_publish" type="hidden" id="original_publish" value="<?php esc_attr_e('Update') ?>" />
-        <input name="save" type="submit" class="button-primary button-large" id="publish" value="<?php esc_attr_e( 'Update' ) ?>" />
+        <input name="save" type="submit" class="button button-primary button-large" id="publish" value="<?php esc_attr_e( 'Update' ) ?>" />
     </div>
     <div class="clear"></div>
@@ -910 +910 @@
 <div id="publishing-action">
 <?php if ( !empty($link->link_id) ) { ?>
-    <input name="save" type="submit" class="button-large button-primary" id="publish" value="<?php esc_attr_e( 'Update Link' ) ?>" />
+    <input name="save" type="submit" class="button button-primary button-large" id="publish" value="<?php esc_attr_e( 'Update Link' ) ?>" />
 <?php } else { ?>
-    <input name="save" type="submit" class="button-large button-primary" id="publish" value="<?php esc_attr_e( 'Add Link' ) ?>" />
+    <input name="save" type="submit" class="button button-primary button-large" id="publish" value="<?php esc_attr_e( 'Add Link' ) ?>" />
 <?php } ?>
 </div>

trunk/src/wp-admin/nav-menus.php

@@ -760 +760 @@
                             <input name="menu-name" id="menu-name" type="text" class="menu-name regular-text menu-item-textbox" <?php echo $menu_name_val . $menu_name_aria_desc; ?> />
                             <div class="publishing-action">
-                                <?php submit_button( empty( $nav_menu_selected_id ) ? __( 'Create Menu' ) : __( 'Save Menu' ), 'button-primary menu-save', 'save_menu', false, array( 'id' => 'save_menu_header' ) ); ?>
+                                <?php submit_button( empty( $nav_menu_selected_id ) ? __( 'Create Menu' ) : __( 'Save Menu' ), 'primary large menu-save', 'save_menu', false, array( 'id' => 'save_menu_header' ) ); ?>
                             </div><!-- END .publishing-action -->
                         </div><!-- END .major-publishing-actions -->
@@ -837 +837 @@
                             <?php endif; ?>
                             <div class="publishing-action">
-                                <?php submit_button( empty( $nav_menu_selected_id ) ? __( 'Create Menu' ) : __( 'Save Menu' ), 'button-primary menu-save', 'save_menu', false, array( 'id' => 'save_menu_footer' ) ); ?>
+                                <?php submit_button( empty( $nav_menu_selected_id ) ? __( 'Create Menu' ) : __( 'Save Menu' ), 'primary large menu-save', 'save_menu', false, array( 'id' => 'save_menu_footer' ) ); ?>
                             </div><!-- END .publishing-action -->
                         </div><!-- END .major-publishing-actions -->