Changeset 38617

Timestamp:

09/17/2016 04:22:03 PM (8 years ago)

Author:

afercia

Message:

Plugins: style the primary action link in the non-js "Installing Plugin" page.

Props curdin, ericlewis, melchoyce, karmatosed.
Fixes #36430.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (1 diff)
• includes/class-plugin-installer-skin.php (modified) (2 diffs)

trunk/src/wp-admin/css/common.css

@@ -2818 +2818 @@
 }
 
+/* For non-js plugin installation screen ticket #36430. */
+.update-php .button.button-primary {
+    margin-right: 1em;
+}
+
 @media screen and ( max-width: 771px ) {
     #plugin-information-title.with-banner {

trunk/src/wp-admin/includes/class-plugin-installer-skin.php

@@ -53 +53 @@
 
         if ( 'import' == $from )
-            $install_actions['activate_plugin'] = '<a href="' . wp_nonce_url( 'plugins.php?action=activate&amp;from=import&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin &amp; Run Importer' ) . '</a>';
+            $install_actions['activate_plugin'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;from=import&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin &amp; Run Importer' ) . '</a>';
         else
-            $install_actions['activate_plugin'] = '<a href="' . wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin' ) . '</a>';
+            $install_actions['activate_plugin'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Activate Plugin' ) . '</a>';
 
         if ( is_multisite() && current_user_can( 'manage_network_plugins' ) ) {
-            $install_actions['network_activate'] = '<a href="' . wp_nonce_url( 'plugins.php?action=activate&amp;networkwide=1&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Network Activate' ) . '</a>';
+            $install_actions['network_activate'] = '<a class="button button-primary" href="' . wp_nonce_url( 'plugins.php?action=activate&amp;networkwide=1&amp;plugin=' . urlencode( $plugin_file ), 'activate-plugin_' . $plugin_file ) . '" target="_parent">' . __( 'Network Activate' ) . '</a>';
             unset( $install_actions['activate_plugin'] );
         }
@@ -91 +91 @@
         $install_actions = apply_filters( 'install_plugin_complete_actions', $install_actions, $this->api, $plugin_file );
 
-        if ( ! empty($install_actions) )
-            $this->feedback(implode(' | ', (array)$install_actions));
+        if ( ! empty( $install_actions ) ) {
+            $this->feedback( implode( ' ', (array) $install_actions ) );
+        }
     }
 }