Changeset 38620 for trunk/src/wp-includes/class-wp-xmlrpc-server.php

Timestamp:

09/18/2016 02:25:13 PM (8 years ago)

Author:

SergeyBiryukov

Message:

XML-RPC: Avoid a PHP notice in ::pingback_ping() if page title was not found.

Props RedSand.
Fixes #36727.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -6324 +6324 @@
 
         preg_match( '|<title>([^<]*?)</title>|is', $remote_source, $matchtitle );
-        $title = $matchtitle[1];
-        if ( empty( $title ) )
-            return $this->pingback_error( 32, __('We cannot find a title on that page.' ) );
+        $title = isset( $matchtitle[1] ) ? $matchtitle[1] : '';
+        if ( empty( $title ) ) {
+            return $this->pingback_error( 32, __( 'We cannot find a title on that page.' ) );
+        }
 
         $remote_source = strip_tags( $remote_source, '<a>' ); // just keep the tag we need