Changeset 38640 for trunk/src/wp-admin/theme-install.php

Timestamp:

09/21/2016 05:53:29 PM (10 years ago)

Author:

afercia

Message:

Accessibility: Add Themes Feature Filter form improvements.

• adds "Apply Filters" and "Clear" at the end of the form
• changes the "Feature Filter", "Apply Filters", "Clear", and "Edit" links in <button> elements
• removes a leftover from [27963]
• clarifies one button text and adds an aria-label attribute
• adds a wp.a11y.speak() message when clicking on "Apply Filters" and no features are selected

Fixes #38086.

File:

• trunk/src/wp-admin/theme-install.php (modified) (4 diffs)

trunk/src/wp-admin/theme-install.php

@@ -38 +38 @@
         'themes'   => false,
         'settings' => array(
-                'isInstall'     => true,
-                'canInstall'    => current_user_can( 'install_themes' ),
-                'installURI'    => current_user_can( 'install_themes' ) ? self_admin_url( 'theme-install.php' ) : null,
-                'adminUrl'      => parse_url( self_admin_url(), PHP_URL_PATH )
+                'isInstall'  => true,
+                'canInstall' => current_user_can( 'install_themes' ),
+                'installURI' => current_user_can( 'install_themes' ) ? self_admin_url( 'theme-install.php' ) : null,
+                'adminUrl'   => parse_url( self_admin_url(), PHP_URL_PATH )
         ),
         'l10n' => array(
-                'addNew' => __( 'Add New Theme' ),
-                'search' => __( 'Search Themes' ),
-                'searchPlaceholder' => __( 'Search themes...' ), // placeholder (no ellipsis)
-                'upload' => __( 'Upload Theme' ),
-                'back'   => __( 'Back' ),
-                'error'  => __( 'An unexpected error occurred. Something may be wrong with WordPress.org or this server&#8217;s configuration. If you continue to have problems, please try the <a href="https://wordpress.org/support/">support forums</a>.' ),
-                'themesFound'   => __( 'Number of Themes found: %d' ),
-                'noThemesFound' => __( 'No themes found. Try a different search.' ),
-                'collapseSidebar'    => __( 'Collapse Sidebar' ),
-                'expandSidebar'      => __( 'Expand Sidebar' ),
+                'addNew'              => __( 'Add New Theme' ),
+                'search'              => __( 'Search Themes' ),
+                'searchPlaceholder'   => __( 'Search themes...' ), // placeholder (no ellipsis)
+                'upload'              => __( 'Upload Theme' ),
+                'back'                => __( 'Back' ),
+                'error'               => __( 'An unexpected error occurred. Something may be wrong with WordPress.org or this server&#8217;s configuration. If you continue to have problems, please try the <a href="https://wordpress.org/support/">support forums</a>.' ),
+                'themesFound'         => __( 'Number of Themes found: %d' ),
+                'noThemesFound'       => __( 'No themes found. Try a different search.' ),
+                'collapseSidebar'     => __( 'Collapse Sidebar' ),
+                'expandSidebar'       => __( 'Expand Sidebar' ),
+                /* translators: hidden accessibility text */
+                'selectFeatureFilter' => __( 'Select one or more Theme features to filter by' ),
         ),
         'installedThemes' => array_keys( $installed_themes ),
@@ -153 +155 @@
                 </ul>
 
-                <a class="drawer-toggle" href="#"><?php _e( 'Feature Filter' ); ?></a>
+                <button type="button" class="button drawer-toggle" aria-expanded="false"><?php _e( 'Feature Filter' ); ?></button>
 
                 <div class="search-form"></div>
@@ -179 +181 @@
                 <div class="filter-drawer">
                         <div class="buttons">
-                                <a class="apply-filters button button-secondary" href="#"><?php _e( 'Apply Filters' ); ?><span></span></a>
-                                <a class="clear-filters button button-secondary" href="#"><?php _e( 'Clear' ); ?></a>
+                                <button type="button" class="apply-filters button"><?php _e( 'Apply Filters' ); ?><span></span></button>
+                                <button type="button" class="clear-filters button" aria-label="<?php esc_attr_e( 'Clear current filters' ); ?>"><?php _e( 'Clear' ); ?></button>
                         </div>
                 <?php
@@ -198 +200 @@
                 }
                 ?>
+                        <div class="buttons">
+                                <button type="button" class="apply-filters button"><?php _e( 'Apply Filters' ); ?><span></span></button>
+                                <button type="button" class="clear-filters button" aria-label="<?php esc_attr_e( 'Clear current filters' ); ?>"><?php _e( 'Clear' ); ?></button>
+                        </div>
                         <div class="filtered-by">
                                 <span><?php _e( 'Filtering by:' ); ?></span>
                                 <div class="tags"></div>
-                                <a href="#"><?php _e( 'Edit' ); ?></a>
+                                <button type="button" class="button-link edit-filters"><?php _e( 'Edit Filters' ); ?></button>
                         </div>
                 </div>