Changeset 38649

Timestamp:

09/25/2016 04:34:34 AM (7 years ago)

Author:

westonruter

Message:

Customize: Opt to disable IE8 support via conditional comments instead of using unreliable Array.prototype.indexOf feature detection.

Deprecate/remove WP_Customize_Manager::customize_preview_html5() and remove document.head polyfill, both of which were only in place for IE8 support.

Props ryankienstra, westonruter.
Fixes #38021.

Location:

trunk/src/wp-includes

Files:

• class-wp-customize-manager.php (modified) (2 diffs)
• js/customize-selective-refresh.js (modified) (1 diff)
• theme.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -741 +741 @@
         add_action( 'wp', array( $this, 'customize_preview_override_404_status' ) );
         add_action( 'wp_head', array( $this, 'customize_preview_base' ) );
-        add_action( 'wp_head', array( $this, 'customize_preview_html5' ) );
         add_action( 'wp_head', array( $this, 'customize_preview_loading_style' ) );
         add_action( 'wp_footer', array( $this, 'customize_preview_settings' ), 20 );
@@ -788 +787 @@
      *
      * @since 3.4.0
-     */
-    public function customize_preview_html5() { ?>
-        <!--[if lt IE 9]>
-        <script type="text/javascript">
-            var e = [ 'abbr', 'article', 'aside', 'audio', 'canvas', 'datalist', 'details',
-                'figure', 'footer', 'header', 'hgroup', 'mark', 'menu', 'meter', 'nav',
-                'output', 'progress', 'section', 'time', 'video' ];
-            for ( var i = 0; i < e.length; i++ ) {
-                document.createElement( e[i] );
-            }
-        </script>
-        <![endif]--><?php
+     * @deprecated 4.7.0 Customizer no longer supports IE8, so all supported browsers recognize HTML5.
+     */
+    public function customize_preview_html5() {
+        _deprecated_function( __FUNCTION__, '4.7.0' );
     }
 

trunk/src/wp-includes/js/customize-selective-refresh.js

@@ -746 +746 @@
         var handleSettingChange, watchSettingChange, unwatchSettingChange;
 
-        // Polyfill for IE8 to support the document.head attribute.
-        if ( ! document.head ) {
-            document.head = $( 'head:first' )[0];
-        }
-
         _.extend( self.data, _customizePartialRefreshExports );
 

trunk/src/wp-includes/theme.php

@@ -2152 +2152 @@
  *
  * @since 3.4.0
+ * @since 4.7.0 Support for IE8 and below is explicitly removed via conditional comments.
  */
 function wp_customize_support_script() {
@@ -2159 +2160 @@
 
     ?>
-    <script type="text/javascript">
-        (function() {
-            var request, b = document.body, c = 'className', cs = 'customize-support', rcs = new RegExp('(^|\\s+)(no-)?'+cs+'(\\s+|$)');
-
-<?php       if ( $cross_domain ): ?>
-            request = (function(){ var xhr = new XMLHttpRequest(); return ('withCredentials' in xhr); })();
-<?php       else: ?>
-            request = true;
-<?php       endif; ?>
-
-            b[c] = b[c].replace( rcs, ' ' );
-            b[c] += ( window.postMessage && request && Array.prototype.indexOf ? ' ' : ' no-' ) + cs;
-        }());
-    </script>
+    <!--[if lte IE 8]>
+        <script type="text/javascript">
+            document.body.className = document.body.className.replace( /(^|\s)(no-)?customize-support(?=\s|$)/, '' ) + ' no-customize-support';
+        </script>
+    <![endif]-->
+    <!--[if gte IE 9]><!-->
+        <script type="text/javascript">
+            (function() {
+                var request, b = document.body, c = 'className', cs = 'customize-support', rcs = new RegExp('(^|\\s+)(no-)?'+cs+'(\\s+|$)');
+
+        <?php   if ( $cross_domain ) : ?>
+                request = (function(){ var xhr = new XMLHttpRequest(); return ('withCredentials' in xhr); })();
+        <?php   else : ?>
+                request = true;
+        <?php   endif; ?>
+
+                b[c] = b[c].replace( rcs, ' ' );
+                // The customizer requires postMessage and CORS (if the site is cross domain)
+                b[c] += ( window.postMessage && request ? ' ' : ' no-' ) + cs;
+            }());
+        </script>
+    <!--<![endif]-->
     <?php
 }