Changeset 38667 for trunk/tests/phpunit/tests/term/query.php

Timestamp:

09/28/2016 03:54:36 AM (7 years ago)

Author:

boonebgorges

Message:

Taxonomy: Use WP_Term_Query when querying for object terms.

The new 'object_ids' parameter for WP_Term_Query allows queries for
terms that "belong to" a given object. This change makes it possible
to use WP_Term_Query inside of wp_get_object_terms(), rather than
assembling a SQL query.

The refactor has a couple of benefits:

• Less redundancy.
• Better consistency in accepted arguments between the term query functions. See #31105.
• Less redundancy.
• Object term queries are now cached. The get_object_term_cache() cache remains, and will be a somewhat less fragile secondary cache in front of the query cache (which is subject to frequent invalidation).
• Less redundancy.

A small breaking change: Previously, if a non-hierarchical taxonomy had
terms that had a non-zero 'parent' (perhaps because of a direct SQL
query), wp_get_object_terms() would respect the 'parent' argument.
This is in contrast to WP_Term_Query and get_terms(), which have
always rejected 'parent' queries for non-hierarchical taxonomies. For
consistency, the behavior of get_terms() is being applied across the
board: passing 'parent' for a non-hierarchical taxonomy will result in
an empty result set (since the cached taxonomy hierarchy will be empty).

Props flixos90, boonebgorges.
See #37198.

File:

• trunk/tests/phpunit/tests/term/query.php (modified) (2 diffs)

trunk/tests/phpunit/tests/term/query.php

@@ -145 +145 @@
 
     /**
+     * @ticket 37198
+     */
+    public function test_order_by_term_order_should_fall_back_on_term_id_when_relationship_table_is_not_being_joined() {
+        register_taxonomy( 'wptests_tax', 'post' );
+        $terms = self::factory()->term->create_many( 2, array( 'taxonomy' => 'wptests_tax' ) );
+        sort( $terms );
+
+        $q = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax',
+            'orderby' => 'term_order',
+            'fields' => 'ids',
+            'hide_empty' => false,
+        ) );
+
+        $this->assertSame( $terms, $q->get_terms() );
+    }
+
+    /**
      * @ticket 37591
      */
@@ -186 +204 @@
         $this->assertEquals( array( $t1, $t2 ), $terms );
     }
+
+    /**
+     * @ticket 37198
+     */
+    public function test_object_ids_single() {
+        register_taxonomy( 'wptests_tax_1', 'post' );
+
+        $p = self::factory()->post->create();
+        $t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax_1' ) );
+
+        wp_set_object_terms( $p, array( $t ), 'wptests_tax_1' );
+
+        $query = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax_1',
+            'object_ids' => $p,
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEqualSets( array( $t ), $query->terms );
+    }
+
+    /**
+     * @ticket 37198
+     */
+    public function test_object_ids_array() {
+        register_taxonomy( 'wptests_tax_1', 'post' );
+
+        $p = self::factory()->post->create();
+        $t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax_1' ) );
+
+        wp_set_object_terms( $p, array( $t ), 'wptests_tax_1' );
+
+        $query = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax_1',
+            'object_ids' => array( $p ),
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEqualSets( array( $t ), $query->terms );
+    }
+
+    /**
+     * @ticket 37198
+     */
+    public function test_duplicates_should_be_removed_for_fields_all() {
+        register_taxonomy( 'wptests_tax_1', 'post' );
+        $posts = self::factory()->post->create_many( 2 );
+        $t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax_1' ) );
+
+        foreach ( $posts as $p ) {
+            wp_set_object_terms( $p, array( $t ), 'wptests_tax_1' );
+        }
+
+        $query = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax_1',
+            'object_ids' => $posts,
+            'fields' => 'all',
+        ) );
+
+        $this->assertSame( 1, count( $query->terms ) );
+        $this->assertSame( $t, reset( $query->terms )->term_id );
+    }
+
+    /**
+     * @ticket 37198
+     */
+    public function test_duplicates_should_not_be_removed_for_fields_all_with_object_id() {
+        register_taxonomy( 'wptests_tax_1', 'post' );
+        $posts = self::factory()->post->create_many( 2 );
+        $t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax_1' ) );
+
+        foreach ( $posts as $p ) {
+            wp_set_object_terms( $p, array( $t ), 'wptests_tax_1' );
+        }
+
+        $query = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax_1',
+            'object_ids' => $posts,
+            'fields' => 'all_with_object_id',
+        ) );
+
+        $this->assertSame( 2, count( $query->terms ) );
+        foreach ( $query->terms as $term ) {
+            $this->assertSame( $t, $term->term_id );
+        }
+    }
+
+    /**
+     * @ticket 37198
+     * @group cache
+     */
+    public function test_object_ids_cache_should_be_invalidated_by_term_relationship_change() {
+        register_taxonomy( 'wptests_tax_1', 'post' );
+
+        $p = self::factory()->post->create();
+        $terms = self::factory()->term->create_many( 2, array( 'taxonomy' => 'wptests_tax_1' ) );
+
+        wp_set_object_terms( $p, array( $terms[0] ), 'wptests_tax_1' );
+
+        $query = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax_1',
+            'object_ids' => $p,
+            'fields' => 'ids',
+        ) );
+        $found = $query->get_terms();
+
+        $this->assertEqualSets( array( $terms[0] ), $found );
+
+        wp_set_object_terms( $p, array( $terms[1] ), 'wptests_tax_1' );
+
+        $query = new WP_Term_Query( array(
+            'taxonomy' => 'wptests_tax_1',
+            'object_ids' => $p,
+            'fields' => 'ids',
+        ) );
+        $found = $query->get_terms();
+
+        $this->assertEqualSets( array( $terms[1] ), $found );
+    }
 }