Changeset 38667 for trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

Timestamp:

09/28/2016 03:54:36 AM (10 years ago)

Author:

boonebgorges

Message:

Taxonomy: Use WP_Term_Query when querying for object terms.

The new 'object_ids' parameter for WP_Term_Query allows queries for
terms that "belong to" a given object. This change makes it possible
to use WP_Term_Query inside of wp_get_object_terms(), rather than
assembling a SQL query.

The refactor has a couple of benefits:

• Less redundancy.
• Better consistency in accepted arguments between the term query functions. See #31105.
• Less redundancy.
• Object term queries are now cached. The get_object_term_cache() cache remains, and will be a somewhat less fragile secondary cache in front of the query cache (which is subject to frequent invalidation).
• Less redundancy.

A small breaking change: Previously, if a non-hierarchical taxonomy had
terms that had a non-zero 'parent' (perhaps because of a direct SQL
query), wp_get_object_terms() would respect the 'parent' argument.
This is in contrast to WP_Term_Query and get_terms(), which have
always rejected 'parent' queries for non-hierarchical taxonomies. For
consistency, the behavior of get_terms() is being applied across the
board: passing 'parent' for a non-hierarchical taxonomy will result in
an empty result set (since the cached taxonomy hierarchy will be empty).

Props flixos90, boonebgorges.
See #37198.

File:

• trunk/tests/phpunit/tests/term/wpGetObjectTerms.php (modified) (3 diffs)

trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

@@ -24 +24 @@
 
         // make sure they're correct
-        $terms = wp_get_object_terms($post_id, $this->taxonomy, array('fields' => 'slugs', 'orderby' => 't.term_id'));
+        $terms = wp_get_object_terms($post_id, $this->taxonomy, array('fields' => 'slugs', 'orderby' => 'term_id'));
         $this->assertEquals( $terms_1_slugs, $terms );
     }
@@ -361 +361 @@
      */
     public function test_parent() {
-        $t1 = self::factory()->term->create( array(
-            'taxonomy' => $this->taxonomy,
-        ) );
-        $t2 = self::factory()->term->create( array(
-            'taxonomy' => $this->taxonomy,
-        ) );
-        $t3 = self::factory()->term->create( array(
-            'taxonomy' => $this->taxonomy,
+        register_taxonomy( 'wptests_tax2', 'post', array(
+            'hierarchical' => true,
+        ) );
+
+        $t1 = self::factory()->term->create( array(
+            'taxonomy' => 'wptests_tax2',
+        ) );
+        $t2 = self::factory()->term->create( array(
+            'taxonomy' => 'wptests_tax2',
+        ) );
+        $t3 = self::factory()->term->create( array(
+            'taxonomy' => 'wptests_tax2',
             'parent' => $t1,
         ) );
         $t4 = self::factory()->term->create( array(
-            'taxonomy' => $this->taxonomy,
+            'taxonomy' => 'wptests_tax2',
             'parent' => $t2,
         ) );
@@ -378 +382 @@
         $p = self::factory()->post->create();
 
-        wp_set_object_terms( $p, array( $t1, $t2, $t3, $t3 ), $this->taxonomy );
-
-        $found = wp_get_object_terms( $p, $this->taxonomy, array(
+        wp_set_object_terms( $p, array( $t1, $t2, $t3, $t3 ), 'wptests_tax2' );
+
+        $found = wp_get_object_terms( $p, 'wptests_tax2', array(
             'parent' => $t1,
             'fields' => 'ids',