Changeset 38672 for trunk/src/wp-admin/custom-header.php

Timestamp:

09/28/2016 07:53:07 PM (10 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/custom-header.php (modified) (4 diffs)

trunk/src/wp-admin/custom-header.php

@@ -577 +577 @@
         <input type="hidden" name="action" value="save" />
         <?php wp_nonce_field( 'custom-header-upload', '_wpnonce-custom-header-upload' ); ?>
-        <?php submit_button( __( 'Upload' ), 'button', 'submit', false ); ?>
+        <?php submit_button( __( 'Upload' ), '', 'submit', false ); ?>
     </p>
     <?php
@@ -635 +635 @@
 <td>
     <p><?php _e( 'This will remove the header image. You will not be able to restore any customizations.' ) ?></p>
-    <?php submit_button( __( 'Remove Header Image' ), 'button', 'removeheader', false ); ?>
+    <?php submit_button( __( 'Remove Header Image' ), '', 'removeheader', false ); ?>
 </td>
 </tr>
@@ -646 +646 @@
 <td>
     <p><?php _e( 'This will restore the original header image. You will not be able to restore any customizations.' ) ?></p>
-    <?php submit_button( __( 'Restore Original Header Image' ), 'button', 'resetheader', false ); ?>
+    <?php submit_button( __( 'Restore Original Header Image' ), '', 'resetheader', false ); ?>
 </td>
 </tr>
@@ -824 +824 @@
     <?php
     if ( isset( $oitar ) && 1 == $oitar && ( current_theme_supports( 'custom-header', 'flex-height' ) || current_theme_supports( 'custom-header', 'flex-width' ) ) )
-        submit_button( __( 'Skip Cropping, Publish Image as Is' ), 'secondary', 'skip-cropping', false );
+        submit_button( __( 'Skip Cropping, Publish Image as Is' ), '', 'skip-cropping', false );
     ?>
     </p>