Changeset 38672 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

09/28/2016 07:53:07 PM (8 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -480 +480 @@
             do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
 
-            submit_button( __( 'Filter' ), 'button', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+            submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
         }
 
@@ -1714 +1714 @@
     ?>
         <p class="submit inline-edit-save">
-            <button type="button" class="button-secondary cancel alignleft"><?php _e( 'Cancel' ); ?></button>
+            <button type="button" class="button cancel alignleft"><?php _e( 'Cancel' ); ?></button>
             <?php if ( ! $bulk ) {
                 wp_nonce_field( 'inlineeditnonce', '_inline_edit', false );
                 ?>
-                <button type="button" class="button-primary save alignright"><?php _e( 'Update' ); ?></button>
+                <button type="button" class="button button-primary save alignright"><?php _e( 'Update' ); ?></button>
                 <span class="spinner"></span>
             <?php } else {
-                submit_button( __( 'Update' ), 'button-primary alignright', 'bulk_edit', false );
+                submit_button( __( 'Update' ), 'primary alignright', 'bulk_edit', false );
             } ?>
             <input type="hidden" name="post_view" value="<?php echo esc_attr( $m ); ?>" />