Changeset 38672 for trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

Timestamp:

09/28/2016 07:53:07 PM (8 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -330 +330 @@
             <div class="wp-full-overlay-sidebar">
                 <div class="wp-full-overlay-header">
-                    <a href="#" class="close-full-overlay button-secondary"><?php _e( 'Close' ); ?></a>
+                    <a href="#" class="close-full-overlay button"><?php _e( 'Close' ); ?></a>
                     <span class="theme-install"></span>
                 </div>
@@ -337 +337 @@
                 </div>
                 <div class="wp-full-overlay-footer">
-                    <button type="button" class="collapse-sidebar button-secondary" aria-expanded="true" aria-label="<?php esc_attr_e( 'Collapse Sidebar' ); ?>">
+                    <button type="button" class="collapse-sidebar button" aria-expanded="true" aria-label="<?php esc_attr_e( 'Collapse Sidebar' ); ?>">
                         <span class="collapse-sidebar-arrow"></span>
                         <span class="collapse-sidebar-label"><?php _e( 'Collapse' ); ?></span>
@@ -399 +399 @@
             switch ( $status ) {
                 case 'update_available':
-                    echo '<a class="theme-install button-primary" href="' . esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ) . '" title="' . esc_attr( sprintf( __( 'Update to version %s' ), $theme->version ) ) . '">' . __( 'Update' ) . '</a>';
+                    echo '<a class="theme-install button button-primary" href="' . esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ) . '" title="' . esc_attr( sprintf( __( 'Update to version %s' ), $theme->version ) ) . '">' . __( 'Update' ) . '</a>';
                     break;
                 case 'newer_installed':
@@ -407 +407 @@
                 case 'install':
                 default:
-                    echo '<a class="theme-install button-primary" href="' . esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ) . '">' . __( 'Install' ) . '</a>';
+                    echo '<a class="theme-install button button-primary" href="' . esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ) . '">' . __( 'Install' ) . '</a>';
                     break;
             } ?>