Changeset 38672 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

09/28/2016 07:53:07 PM (8 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (2 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -428 +428 @@
             <label class="screen-reader-text" for="search-users"><?php _e( 'Search Users' ); ?></label>
             <input type="search" name="s" value="" size="30" autocomplete="off" id="search-users"/>
-            <?php submit_button( __( 'Search Users' ), 'button', false, false, array( 'id' => 'submit_users' ) ); ?>
+            <?php submit_button( __( 'Search Users' ), '', false, false, array( 'id' => 'submit_users' ) ); ?>
         </p>
     </form>
@@ -436 +436 @@
             <label class="screen-reader-text" for="search-sites"><?php _e( 'Search Sites' ); ?></label>
             <input type="search" name="s" value="" size="30" autocomplete="off" id="search-sites"/>
-            <?php submit_button( __( 'Search Sites' ), 'button', false, false, array( 'id' => 'submit_sites' ) ); ?>
+            <?php submit_button( __( 'Search Sites' ), '', false, false, array( 'id' => 'submit_sites' ) ); ?>
         </p>
     </form>