Make WordPress Core


Ignore:
Timestamp:
09/28/2016 07:53:07 PM (5 years ago)
Author:
afercia
Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

  • Adds the button class to all primary buttons make them responsive
  • Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
  • Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
  • Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/file.php

    r38470 r38672  
    12621262    <p class="request-filesystem-credentials-action-buttons">
    12631263        <button class="button cancel-button" data-js-action="close" type="button"><?php _e( 'Cancel' ); ?></button>
    1264         <?php submit_button( __( 'Proceed' ), 'button', 'upgrade', false ); ?>
     1264        <?php submit_button( __( 'Proceed' ), '', 'upgrade', false ); ?>
    12651265    </p>
    12661266</div>
Note: See TracChangeset for help on using the changeset viewer.