Changeset 38672 for trunk/src/wp-admin/includes/template.php

Timestamp:

09/28/2016 07:53:07 PM (9 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/includes/template.php (modified) (4 diffs)

trunk/src/wp-admin/includes/template.php

@@ -424 +424 @@
 
     <p id="replysubmit" class="submit">
-    <a href="#comments-form" class="save button-primary alignright">
+    <a href="#comments-form" class="save button button-primary alignright">
     <span id="addbtn" style="display:none;"><?php _e('Add Comment'); ?></span>
     <span id="savebtn" style="display:none;"><?php _e('Update Comment'); ?></span>
     <span id="replybtn" style="display:none;"><?php _e('Submit Reply'); ?></span></a>
-    <a href="#comments-form" class="cancel button-secondary alignleft"><?php _e('Cancel'); ?></a>
+    <a href="#comments-form" class="cancel button alignleft"><?php _e('Cancel'); ?></a>
     <span class="waiting spinner"></span>
     <span class="error" style="display:none;"></span>
@@ -658 +658 @@
 <tr><td colspan="2">
 <div class="submit">
-<?php submit_button( __( 'Add Custom Field' ), 'secondary', 'addmeta', false, array( 'id' => 'newmeta-submit', 'data-wp-lists' => 'add:the-list:newmeta' ) ); ?>
+<?php submit_button( __( 'Add Custom Field' ), '', 'addmeta', false, array( 'id' => 'newmeta-submit', 'data-wp-lists' => 'add:the-list:newmeta' ) ); ?>
 </div>
 <?php wp_nonce_field( 'add-meta', '_ajax_nonce-add-meta', false ); ?>
@@ -1514 +1514 @@
         </div>
         <div class="find-box-buttons">
-            <?php submit_button( __( 'Select' ), 'button-primary alignright', 'find-posts-submit', false ); ?>
+            <?php submit_button( __( 'Select' ), 'primary alignright', 'find-posts-submit', false ); ?>
             <div class="clear"></div>
         </div>
@@ -1915 +1915 @@
         $classes[] = in_array( $t, $button_shorthand ) ? 'button-' . $t : $t;
     }
-    $class = implode( ' ', array_unique( $classes ) );
+    // Remove empty items, remove duplicate items, and finally build a string.
+    $class = implode( ' ', array_unique( array_filter( $classes ) ) );
 
     if ( 'delete' === $type )
-        $class = 'button-secondary delete';
+        $class = 'button delete';
 
     $text = $text ? $text : __( 'Save Changes' );