Changeset 38672 for trunk/src/wp-admin/theme-install.php

Timestamp:

09/28/2016 07:53:07 PM (9 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/theme-install.php (modified) (4 diffs)

trunk/src/wp-admin/theme-install.php

@@ -175 +175 @@
                 <input type="hidden" id="wporg-username-nonce" name="_wpnonce" value="<?php echo esc_attr( wp_create_nonce( $action ) ); ?>" />
                 <input type="search" id="wporg-username-input" value="<?php echo esc_attr( $user ); ?>" />
-                <input type="button" class="button button-secondary favorites-form-submit" value="<?php esc_attr_e( 'Get Favorites' ); ?>" />
+                <input type="button" class="button favorites-form-submit" value="<?php esc_attr_e( 'Get Favorites' ); ?>" />
             </p>
         </div>
@@ -263 +263 @@
             <# } #>
             <# if ( data.customize_url ) { #>
-                <a class="button button-secondary load-customize" href="{{ data.customize_url }}"><?php _e( 'Live Preview' ); ?></a>
+                <a class="button load-customize" href="{{ data.customize_url }}"><?php _e( 'Live Preview' ); ?></a>
             <# } else { #>
-                <button class="button-secondary preview install-theme-preview"><?php _e( 'Preview' ); ?></button>
+                <button class="button preview install-theme-preview"><?php _e( 'Preview' ); ?></button>
             <# } #>
         <# } else { #>
@@ -273 +273 @@
             ?>
             <a class="button button-primary theme-install" data-name="{{ data.name }}" data-slug="{{ data.id }}" href="{{ data.install_url }}" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Install' ); ?></a>
-            <button class="button-secondary preview install-theme-preview"><?php _e( 'Preview' ); ?></button>
+            <button class="button preview install-theme-preview"><?php _e( 'Preview' ); ?></button>
         <# } #>
     </div>
@@ -326 +326 @@
             </div>
             <div class="wp-full-overlay-footer">
-                <button type="button" class="collapse-sidebar button-secondary" aria-expanded="true" aria-label="<?php esc_attr_e( 'Collapse Sidebar' ); ?>">
+                <button type="button" class="collapse-sidebar button" aria-expanded="true" aria-label="<?php esc_attr_e( 'Collapse Sidebar' ); ?>">
                     <span class="collapse-sidebar-arrow"></span>
                     <span class="collapse-sidebar-label"><?php _e( 'Collapse' ); ?></span>