Changeset 38672 for trunk/src/wp-admin/update-core.php

Timestamp:

09/28/2016 07:53:07 PM (9 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/update-core.php (modified) (2 diffs)

trunk/src/wp-admin/update-core.php

@@ -93 +93 @@
     if ( $show_buttons ) {
         if ( $first_pass ) {
-            submit_button( $submit, $current ? 'button' : 'primary regular', 'upgrade', false );
+            submit_button( $submit, $current ? '' : 'primary regular', 'upgrade', false );
             $first_pass = false;
         } else {
-            submit_button( $submit, 'button', 'upgrade', false );
+            submit_button( $submit, '', 'upgrade', false );
         }
         echo '&nbsp;<a href="' . esc_url( $update->download ) . '" class="button">' . $download . '</a>&nbsp;';
@@ -102 +102 @@
     if ( 'en_US' != $update->locale )
         if ( !isset( $update->dismissed ) || !$update->dismissed )
-            submit_button( __('Hide this update'), 'button', 'dismiss', false );
+            submit_button( __( 'Hide this update' ), '', 'dismiss', false );
         else
-            submit_button( __('Bring back this update'), 'button', 'undismiss', false );
+            submit_button( __( 'Bring back this update' ), '', 'undismiss', false );
     echo '</p>';
     if ( 'en_US' != $update->locale && ( !isset($wp_local_package) || $wp_local_package != $update->locale ) )