Changeset 38672 for trunk/src/wp-admin/widgets.php

Timestamp:

09/28/2016 07:53:07 PM (8 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/widgets.php (modified) (2 diffs)

trunk/src/wp-admin/widgets.php

@@ -316 +316 @@
 <?php
     } else {
-        submit_button( __( 'Delete' ), 'button alignleft', 'removewidget', false );
-    }
-    submit_button( __( 'Save Widget' ), 'button-primary alignright', 'savewidget', false ); ?>
+        submit_button( __( 'Delete' ), 'alignleft', 'removewidget', false );
+    }
+    submit_button( __( 'Save Widget' ), 'primary alignright', 'savewidget', false ); ?>
     <input type="hidden" name="widget-id" class="widget-id" value="<?php echo esc_attr($widget_id); ?>" />
     <input type="hidden" name="id_base" class="id_base" value="<?php echo esc_attr($id_base); ?>" />
@@ -501 +501 @@
     <ul class="widgets-chooser-sidebars"></ul>
     <div class="widgets-chooser-actions">
-        <button class="button-secondary"><?php _e( 'Cancel' ); ?></button>
-        <button class="button-primary"><?php _e( 'Add Widget' ); ?></button>
+        <button class="button widgets-chooser-cancel"><?php _e( 'Cancel' ); ?></button>
+        <button class="button button-primary widgets-chooser-add"><?php _e( 'Add Widget' ); ?></button>
     </div>
 </div>