Changeset 38673

Timestamp:

09/29/2016 01:20:10 AM (8 years ago)

Author:

joemcgill

Message:

Media: Use wp_basename() to create attachment titles from filenames.

In [38294], pathinfo() was used with the PATHINFO_BASENAME constant to
get the basename of the file to be used as an attachment title, which depends
on PHP locale and can cause issues with UTF-8 characters. This uses
wp_basename() instead, which is a more i18n-friendly version of basename().

Props SergeyBiryukov.
Fixes #37608, #37989.

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -284 +284 @@
         return new WP_Error( 'upload_error', $file['error'] );
 
-    $name = pathinfo( $_FILES[$file_id]['name'], PATHINFO_FILENAME );
+    $name = $_FILES[$file_id]['name'];
+    $ext  = pathinfo( $name, PATHINFO_EXTENSION );
+    $name = wp_basename( $name, ".$ext" );
 
     $url = $file['url'];