Changeset 38677 for trunk/tests/phpunit/tests/term/getTermBy.php

Timestamp:

09/29/2016 10:35:32 PM (10 years ago)

Author:

ocean90

Message:

Taxonomy: Use WP_Term_Query in get_term_by().

WP_Term_Query already supports querying terms by 'slug', 'name', and 'term_taxonomy_id'. Its additional arguments allow us to generate nearly the same SQL queries as before.
This change has one yuge benefit: the term queries are now cached.

Add tests to increase coverage of get_term_by().

Props spacedmonkey, boonebgorges, johnjamesjacoby, pento, ocean90.
Fixes #21760.

File:

• trunk/tests/phpunit/tests/term/getTermBy.php (modified) (3 diffs)

trunk/tests/phpunit/tests/term/getTermBy.php

@@ -5 +5 @@
  */
 class Tests_Term_GetTermBy extends WP_UnitTestCase {
+
+        function test_get_term_by_slug() {
+                $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
+                $term2 = get_term_by( 'slug', 'foo', 'category' );
+                $this->assertEquals( get_term( $term1['term_id'], 'category' ), $term2 );
+        }
+
+        function test_get_term_by_name() {
+                $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
+                $term2 = get_term_by( 'name', 'Foo', 'category' );
+                $this->assertEquals( get_term( $term1['term_id'], 'category' ), $term2 );
+        }
+
+        function test_get_term_by_id() {
+                $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
+                $term2 = get_term_by( 'id', $term1['term_id'], 'category' );
+                $this->assertEquals( get_term( $term1['term_id'], 'category' ), $term2 );
+        }
+
+        /**
+         * 'term_id' is an alias of 'id'.
+         */
+        function test_get_term_by_term_id() {
+                $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
+                $term2 = get_term_by( 'term_id', $term1['term_id'], 'category' );
+                $this->assertEquals( get_term( $term1['term_id'], 'category' ), $term2 );
+        }
+
         /**
          * @ticket 21651
@@ -12 +40 @@
                 $term2 = get_term_by( 'term_taxonomy_id', $term1['term_taxonomy_id'], 'category' );
                 $this->assertEquals( get_term( $term1['term_id'], 'category' ), $term2 );
+        }
+
+        function test_get_term_by_unknown() {
+                wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
+                $term2 = get_term_by( 'unknown', 'foo', 'category' );
+                $this->assertFalse( $term2 );
         }
 
@@ -88 +122 @@
                 $this->assertSame( $num_queries, $wpdb->num_queries );
         }
+
+        /**
+         * @ticket 21760
+         */
+        public function test_should_unslash_name() {
+                register_taxonomy( 'wptests_tax', 'post' );
+                $term_name = 'Foo " \o/';
+                $term_name_slashed = wp_slash( $term_name );
+                $t = self::factory()->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'name' => $term_name_slashed,
+                ) );
+
+                $found = get_term_by( 'name', $term_name_slashed, 'wptests_tax' );
+
+                $this->assertTrue( $found instanceof WP_Term );
+                $this->assertSame( $t, $found->term_id );
+                $this->assertSame( $term_name, $found->name );
+        }
+
+        /**
+         * @ticket 21760
+         */
+        public function test_should_sanitize_slug() {
+                register_taxonomy( 'wptests_tax', 'post' );
+                $t1 = self::factory()->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'slug' => 'foo-foo',
+                ) );
+
+                // Whitespace should get replaced by a '-'.
+                $found1 = get_term_by( 'slug', 'foo foo', 'wptests_tax' );
+
+                $this->assertTrue( $found1 instanceof WP_Term );
+                $this->assertSame( $t1, $found1->term_id );
+
+                $t2 = self::factory()->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'slug' => '%e4%bb%aa%e8%a1%a8%e7%9b%98',
+                ) );
+
+                // Slug should get urlencoded.
+                $found2 = get_term_by( 'slug', '仪表盘', 'wptests_tax' );
+
+                $this->assertTrue( $found2 instanceof WP_Term );
+                $this->assertSame( $t2, $found2->term_id );
+        }
+
+        /**
+         * @ticket 21760
+         */
+        public function test_query_should_not_contain_order_by_clause() {
+                global $wpdb;
+
+                $term_id = $this->factory->term->create( array( 'name' => 'burrito', 'taxonomy' => 'post_tag' ) );
+                $found = get_term_by( 'name', 'burrito', 'post_tag' );
+                $this->assertSame( $term_id, $found->term_id );
+                $this->assertNotContains( 'ORDER BY', $wpdb->last_query );
+        }
+
+        /**
+         * @ticket 21760
+         */
+        public function test_query_should_contain_limit_clause() {
+                global $wpdb;
+
+                $term_id = $this->factory->term->create( array( 'name' => 'burrito', 'taxonomy' => 'post_tag' ) );
+                $found = get_term_by( 'name', 'burrito', 'post_tag' );
+                $this->assertSame( $term_id, $found->term_id );
+                $this->assertContains( 'LIMIT 1', $wpdb->last_query );
+        }
 }