Changeset 38678 for trunk/tests/phpunit/tests/includes/helpers.php

Timestamp:

09/30/2016 03:15:36 AM (8 years ago)

Author:

boonebgorges

Message:

Tests: Reset post-related globals after each test.

Globals like $pages were leaking between tests, resulting in various
bits of weirdness.

Globals will kill WordPress. Globals are killing WordPress.

See #38196.

File:

• trunk/tests/phpunit/tests/includes/helpers.php (modified) (1 diff)

trunk/tests/phpunit/tests/includes/helpers.php

@@ -213 +213 @@
         wp_die( new WP_Error( 'test', 'test' ) );
     }
+
+    /**
+     * This test is just a setup for the one that follows.
+     *
+     * @ticket 38196
+     */
+    public function test_setup_postdata_globals_should_be_reset_on_teardown__setup() {
+        $post = self::factory()->post->create_and_get();
+        $GLOBALS['wp_query'] = new WP_Query();
+        $GLOBALS['wp_query']->setup_postdata( $post );
+        $this->assertNotEmpty( $post );
+    }
+
+    /**
+     * @ticket 38196
+     */
+    public function test_setup_postdata_globals_should_be_reset_on_teardown() {
+        $globals = array( 'post', 'id', 'authordata', 'currentday', 'currentmonth', 'page', 'pages', 'multipage', 'more', 'numpages' );
+
+        foreach ( $globals as $global ) {
+            $this->assertTrue( ! isset( $GLOBALS[ $global ] ), $global );
+        }
+    }
 }