Changeset 38693

Timestamp:

09/30/2016 09:42:01 PM (8 years ago)

Author:

ocean90

Message:

Embeds: Add oEmbed support for User, List and Like Twitter timelines.

Props earnjam.
Fixes #38003.

Location:

trunk

Files:

• src/wp-includes/class-oembed.php (modified) (2 diffs)
• tests/phpunit/tests/oembed.php (modified) (2 diffs)

trunk/src/wp-includes/class-oembed.php

@@ -73 +73 @@
             '#https?://poll\.fm/.*#i'                             => array( 'https://polldaddy.com/oembed/',                             true  ),
             '#https?://(www\.)?funnyordie\.com/videos/.*#i'       => array( 'http://www.funnyordie.com/oembed',                          true  ),
-            '#https?://(www\.)?twitter\.com/.+?/status(es)?/.*#i' => array( 'https://publish.twitter.com/oembed',                        true  ),
-            '#https?://(www\.)?twitter\.com/.+?/timelines/.*#i'   => array( 'https://publish.twitter.com/oembed',                        true  ),
+            '#https?://(www\.)?twitter\.com/\w{1,15}/status(es)?/.*#i' => array( 'https://publish.twitter.com/oembed',                        true  ),
+            '#https?://(www\.)?twitter\.com/\w{1,15}$#i'               => array( 'https://publish.twitter.com/oembed',                        true  ),
+            '#https?://(www\.)?twitter\.com/\w{1,15}/likes$#i'         => array( 'https://publish.twitter.com/oembed',                        true  ),
+            '#https?://(www\.)?twitter\.com/\w{1,15}/lists/.*#i'       => array( 'https://publish.twitter.com/oembed',                        true  ),
+            '#https?://(www\.)?twitter\.com/\w{1,15}/timelines/.*#i'   => array( 'https://publish.twitter.com/oembed',                        true  ),
             '#https?://(www\.)?twitter\.com/i/moments/.*#i'       => array( 'https://publish.twitter.com/oembed',                        true  ),
             '#https?://vine\.co/v/.*#i'                           => array( 'https://vine.co/oembed.{format}',                           true  ),
@@ -176 +179 @@
          * | Twitter      | twitter.com/moments   |      Yes       | 4.5.0     |
          * | Facebook     | facebook.com          |      Yes       | 4.7.0     |
+         * | Twitter      | twitter.com/user      |      Yes       | 4.7.0     |
+         * | Twitter      | twitter.com/likes     |      Yes       | 4.7.0     |
+         * | Twitter      | twitter.com/lists     |      Yes       | 4.7.0     |
          *
          * No longer supported providers:

trunk/tests/phpunit/tests/oembed.php

@@ -21 +21 @@
         'polldaddy-shorturl'   => '#https?://poll\.fm/.*#i',
         'funnyordie'           => '#https?://(www\.)?funnyordie\.com/videos/.*#i',
-        'twitter'              => '#https?://(www\.)?twitter\.com/.+?/status(es)?/.*#i',
-        'twitter-timeline'     => '#https?://(www\.)?twitter\.com/.+?/timelines/.*#i',
+        'twitter'              => '#https?://(www\.)?twitter\.com/\w{1,15}/status(es)?/.*#i',
+        'twitter-user'         => '#https?://(www\.)?twitter\.com/\w{1,15}$#i',
+        'twitter-likes'        => '#https?://(www\.)?twitter\.com/\w{1,15}/likes$#i',
+        'twitter-list'         => '#https?://(www\.)?twitter\.com/\w{1,15}/lists/.*#i',
+        'twitter-timeline'     => '#https?://(www\.)?twitter\.com/\w{1,15}/timelines/.*#i',
         'twitter-moment'       => '#https?://(www\.)?twitter\.com/i/moments/.*#i',
         'vine'                 => '#https?://vine\.co/v/.*#i',
@@ -585 +588 @@
             ),
             array(
+                $providers['twitter-user'],
+                array(
+                    'https://twitter.com/WordPress',
+                ),
+            ),
+            array(
+                $providers['twitter-likes'],
+                array(
+                    'https://twitter.com/WordPress/likes',
+                ),
+            ),
+            array(
+                $providers['twitter-list'],
+                array(
+                    'https://twitter.com/TwitterDev/lists/national-parks',
+                ),
+            ),
+            array(
                 $providers['twitter-timeline'],
                 array(