Changeset 38698 for trunk/src/wp-admin/includes/class-wp-terms-list-table.php

Timestamp:

09/30/2016 10:39:32 PM (8 years ago)

Author:

johnbillion

Message:

Taxonomy: Introduce more fine grained capabilities for managing taxonomy terms.

This introduces the singular edit_term, delete_term, and assign_term meta capabilities for terms, and switches the base capability name for tags from manage_categories to manage_post_tags and the corresponding edit_post_tags, delete_post_tags, and assign_post_tags.

All of these capabilities ultimately map to manage_categories so by default there is no change in the behaviour of the capabilities for categories, tags, or custom taxonomies. The map_meta_cap filter and the capabilities argument when registering a taxonomy now allow for control over editing, deleting, and assigning individual terms, as well as a separation of capabilities for tags from those of categories.

Fixes #35614
Props johnjamesjacoby for feedback

File:

• trunk/src/wp-admin/includes/class-wp-terms-list-table.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-terms-list-table.php

@@ -152 +152 @@
     protected function get_bulk_actions() {
         $actions = array();
-        $actions['delete'] = __( 'Delete' );
+
+        if ( current_user_can( get_taxonomy( $this->screen->taxonomy )->cap->delete_terms ) ) {
+            $actions['delete'] = __( 'Delete' );
+        }
 
         return $actions;
@@ -333 +336 @@
      */
     public function column_cb( $tag ) {
-        $default_term = get_option( 'default_' . $this->screen->taxonomy );
-
-        if ( current_user_can( get_taxonomy( $this->screen->taxonomy )->cap->delete_terms ) && $tag->term_id != $default_term )
+        if ( current_user_can( 'delete_term', $tag->term_id ) ) {
             return '<label class="screen-reader-text" for="cb-select-' . $tag->term_id . '">' . sprintf( __( 'Select %s' ), $tag->name ) . '</label>'
                 . '<input type="checkbox" name="delete_tags[]" value="' . $tag->term_id . '" id="cb-select-' . $tag->term_id . '" />';
+        }
 
         return '&nbsp;';
@@ -424 +426 @@
         $taxonomy = $this->screen->taxonomy;
         $tax = get_taxonomy( $taxonomy );
-        $default_term = get_option( 'default_' . $taxonomy );
-
         $uri = wp_doing_ajax() ? wp_get_referer() : $_SERVER['REQUEST_URI'];
 
@@ -435 +435 @@
 
         $actions = array();
-        if ( current_user_can( $tax->cap->edit_terms ) ) {
+        if ( current_user_can( 'edit_term', $tag->term_id ) ) {
             $actions['edit'] = sprintf(
                 '<a href="%s" aria-label="%s">%s</a>',
@@ -450 +450 @@
             );
         }
-        if ( current_user_can( $tax->cap->delete_terms ) && $tag->term_id != $default_term ) {
+        if ( current_user_can( 'delete_term', $tag->term_id ) ) {
             $actions['delete'] = sprintf(
                 '<a href="%s" class="delete-tag aria-button-if-js" aria-label="%s">%s</a>',