Changeset 38698 for trunk/tests/phpunit/tests/user/capabilities.php

Timestamp:

09/30/2016 10:39:32 PM (10 years ago)

Author:

johnbillion

Message:

Taxonomy: Introduce more fine grained capabilities for managing taxonomy terms.

This introduces the singular edit_term, delete_term, and assign_term meta capabilities for terms, and switches the base capability name for tags from manage_categories to manage_post_tags and the corresponding edit_post_tags, delete_post_tags, and assign_post_tags.

All of these capabilities ultimately map to manage_categories so by default there is no change in the behaviour of the capabilities for categories, tags, or custom taxonomies. The map_meta_cap filter and the capabilities argument when registering a taxonomy now allow for control over editing, deleting, and assigning individual terms, as well as a separation of capabilities for tags from those of categories.

Fixes #35614
Props johnjamesjacoby for feedback

File:

• trunk/tests/phpunit/tests/user/capabilities.php (modified) (4 diffs)

trunk/tests/phpunit/tests/user/capabilities.php

@@ -224 +224 @@
                         'delete_site'            => array( 'administrator' ),
                         'add_users'              => array( 'administrator' ),
+
+                        'edit_categories'        => array( 'administrator', 'editor' ),
+                        'delete_categories'      => array( 'administrator', 'editor' ),
+                        'manage_post_tags'       => array( 'administrator', 'editor' ),
+                        'edit_post_tags'         => array( 'administrator', 'editor' ),
+                        'delete_post_tags'       => array( 'administrator', 'editor' ),
+
+                        'assign_categories'      => array( 'administrator', 'editor', 'author', 'contributor' ),
+                        'assign_post_tags'       => array( 'administrator', 'editor', 'author', 'contributor' ),
                 );
         }
@@ -243 +252 @@
                         'delete_site'            => array( 'administrator' ),
                         'add_users'              => array( 'administrator' ),
+
+                        'edit_categories'        => array( 'administrator', 'editor' ),
+                        'delete_categories'      => array( 'administrator', 'editor' ),
+                        'manage_post_tags'       => array( 'administrator', 'editor' ),
+                        'edit_post_tags'         => array( 'administrator', 'editor' ),
+                        'delete_post_tags'       => array( 'administrator', 'editor' ),
+
+                        'assign_categories'      => array( 'administrator', 'editor', 'author', 'contributor' ),
+                        'assign_post_tags'       => array( 'administrator', 'editor', 'author', 'contributor' ),
                 );
         }
@@ -400 +418 @@
                         $expected['add_post_meta'],
                         $expected['edit_comment'],
+                        $expected['edit_term'],
+                        $expected['delete_term'],
+                        $expected['assign_term'],
                         $expected['delete_user']
                 );
@@ -1077 +1098 @@
                         ), $caps, "Meta cap: {$meta_cap}" );
                 }
+        }
+
+        /**
+         * @dataProvider dataTaxonomies
+         *
+         * @ticket 35614
+         */
+        public function test_default_taxonomy_term_cannot_be_deleted( $taxonomy ) {
+                if ( ! taxonomy_exists( $taxonomy ) ) {
+                        register_taxonomy( $taxonomy, 'post' );
+                }
+
+                $tax  = get_taxonomy( $taxonomy );
+                $user = self::$users['administrator'];
+                $term = self::factory()->term->create_and_get( array(
+                        'taxonomy' => $taxonomy,
+                ) );
+
+                update_option( "default_{$taxonomy}", $term->term_id );
+
+                $this->assertTrue( user_can( $user->ID, $tax->cap->delete_terms ) );
+                $this->assertFalse( user_can( $user->ID, 'delete_term', $term->term_id ) );
+        }
+
+        /**
+         * @dataProvider dataTaxonomies
+         *
+         * @ticket 35614
+         */
+        public function test_taxonomy_caps_map_correctly_to_their_meta_cap( $taxonomy ) {
+                if ( ! taxonomy_exists( $taxonomy ) ) {
+                        register_taxonomy( $taxonomy, 'post' );
+                }
+
+                $tax  = get_taxonomy( $taxonomy );
+                $term = self::factory()->term->create_and_get( array(
+                        'taxonomy' => $taxonomy,
+                ) );
+
+                foreach ( self::$users as $role => $user ) {
+                        $this->assertSame(
+                                user_can( $user->ID, 'edit_term', $term->term_id ),
+                                user_can( $user->ID, $tax->cap->edit_terms ),
+                                "Role: {$role}"
+                        );
+                        $this->assertSame(
+                                user_can( $user->ID, 'delete_term', $term->term_id ),
+                                user_can( $user->ID, $tax->cap->delete_terms ),
+                                "Role: {$role}"
+                        );
+                        $this->assertSame(
+                                user_can( $user->ID, 'assign_term', $term->term_id ),
+                                user_can( $user->ID, $tax->cap->assign_terms ),
+                                "Role: {$role}"
+                        );
+                }
+
         }