Changeset 38700

Timestamp:

10/02/2016 02:37:54 PM (8 years ago)

Author:

afercia

Message:

Accessibility: Editor, Publish meta box: remove a stray label and redundant CSS.

Also, adds a role="button" attribute to the "Edit" links.

Props iseulde.
Fixes #28411.

Location:

trunk/src/wp-admin

Files:

• css/edit.css (modified) (4 diffs)
• css/forms.css (modified) (1 diff)
• includes/meta-boxes.php (modified) (4 diffs)

trunk/src/wp-admin/css/edit.css

@@ -452 +452 @@
 }
 
-#misc-publishing-actions label[for="post_status"]:before,
+#post-body .misc-pub-post-status:before,
 #post-body #visibility:before,
 .curtime #timestamp:before,
@@ -460 +460 @@
 }
 
+#post-body .misc-pub-post-status:before,
 #post-body #visibility:before,
 .curtime #timestamp:before,
@@ -466 +467 @@
     speak: none;
     display: inline-block;
-    padding: 0 2px 0 0;
-    top: 0;
-    left: -1px;
-    position: relative;
+    margin-left: -1px;
+    padding-right: 3px;
     vertical-align: top;
     -webkit-font-smoothing: antialiased;
     -moz-osx-font-smoothing: grayscale;
-    text-decoration: none !important;
+}
+
+#post-body .misc-pub-post-status:before {
+    content: "\f173";
 }
 
@@ -482 +484 @@
 .curtime #timestamp:before {
     content: "\f145";
+    position: relative;
     top: -1px;
 }

trunk/src/wp-admin/css/forms.css

@@ -459 +459 @@
 }
 
-#misc-publishing-actions label[for="post_status"]:before {
-    content: "\f173";
-    display: inline-block;
-    font: normal 20px/1 dashicons;
-    speak: none;
-    left: -1px;
-    padding: 0 5px 0 0;
-    position: relative;
-    top: 0;
-    text-decoration: none !important;
-    vertical-align: top;
-    -webkit-font-smoothing: antialiased;
-    -moz-osx-font-smoothing: grayscale;
-}
-
 #pass-strength-result {
     background-color: #eee;

trunk/src/wp-admin/includes/meta-boxes.php

@@ -75 +75 @@
 <div id="misc-publishing-actions">
 
-<div class="misc-pub-section misc-pub-post-status"><label for="post_status"><?php _e('Status:') ?></label>
-<span id="post-status-display">
-<?php
+<div class="misc-pub-section misc-pub-post-status">
+<?php _e( 'Status:' ) ?> <span id="post-status-display"><?php
+
 switch ( $post->post_status ) {
     case 'private':
@@ -99 +99 @@
 </span>
 <?php if ( 'publish' == $post->post_status || 'private' == $post->post_status || $can_publish ) { ?>
-<a href="#post_status" <?php if ( 'private' == $post->post_status ) { ?>style="display:none;" <?php } ?>class="edit-post-status hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit status' ); ?></span></a>
+<a href="#post_status" <?php if ( 'private' == $post->post_status ) { ?>style="display:none;" <?php } ?>class="edit-post-status hide-if-no-js" role="button"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit status' ); ?></span></a>
 
 <div id="post-status-select" class="hide-if-js">
 <input type="hidden" name="hidden_post_status" id="hidden_post_status" value="<?php echo esc_attr( ('auto-draft' == $post->post_status ) ? 'draft' : $post->post_status); ?>" />
-<select name='post_status' id='post_status'>
+<label for="post_status" class="screen-reader-text"><?php _e( 'Set status' ) ?></label>
+<select name="post_status" id="post_status">
 <?php if ( 'publish' == $post->post_status ) : ?>
 <option<?php selected( $post->post_status, 'publish' ); ?> value='publish'><?php _e('Published') ?></option>
@@ -145 +146 @@
 echo esc_html( $visibility_trans ); ?></span>
 <?php if ( $can_publish ) { ?>
-<a href="#visibility" class="edit-visibility hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit visibility' ); ?></span></a>
+<a href="#visibility" class="edit-visibility hide-if-no-js" role="button"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit visibility' ); ?></span></a>
 
 <div id="post-visibility-select" class="hide-if-js">
@@ -202 +203 @@
     <span id="timestamp">
     <?php printf($stamp, $date); ?></span>
-    <a href="#edit_timestamp" class="edit-timestamp hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit date and time' ); ?></span></a>
+    <a href="#edit_timestamp" class="edit-timestamp hide-if-no-js" role="button"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit date and time' ); ?></span></a>
     <fieldset id="timestampdiv" class="hide-if-js">
     <legend class="screen-reader-text"><?php _e( 'Date and time' ); ?></legend>