Changeset 38703

Timestamp:

10/03/2016 06:36:19 AM (10 years ago)

Author:

swissspidy

Message:

Plugins: Fix checkbox selection when searching for installed plugins.

Since the plugin search works via Ajax, the JavaScript events need to delegated in order for the checkboxes to work properly.

Props afercia.
Fixes #37973.

File:

• trunk/src/wp-admin/js/common.js (modified) (3 diffs)

trunk/src/wp-admin/js/common.js

@@ -427 +427 @@
         screenMeta.init();
 
-        // check all checkboxes
-        $('tbody').children().children('.check-column').find(':checkbox').click( function(e) {
-                if ( 'undefined' == e.shiftKey ) { return true; }
-                if ( e.shiftKey ) {
+        // This event needs to be delegated. Ticket #37973.
+        $body.on( 'click', 'tbody .check-column :checkbox', function( even ) {
+                // Shift click to select a range of checkboxes.
+                if ( 'undefined' == event.shiftKey ) { return true; }
+                if ( event.shiftKey ) {
                         if ( !lastClicked ) { return true; }
                         checks = $( lastClicked ).closest( 'form' ).find( ':checkbox' ).filter( ':visible:enabled' );
@@ -448 +449 @@
                 lastClicked = this;
 
-                // toggle "check all" checkboxes
+                // Toggle the "Select all" checkboxes depending if the other ones are all checked or not.
                 var unchecked = $(this).closest('tbody').find(':checkbox').filter(':visible:enabled').not(':checked');
                 $(this).closest('table').children('thead, tfoot').find(':checkbox').prop('checked', function() {
@@ -457 +458 @@
         });
 
-        $('thead, tfoot').find('.check-column :checkbox').on( 'click.wp-toggle-checkboxes', function( event ) {
+        // This event needs to be delegated. Ticket #37973.
+        $body.on( 'click.wp-toggle-checkboxes', 'thead .check-column :checkbox, tfoot .check-column :checkbox', function( event ) {
                 var $this = $(this),
                         $table = $this.closest( 'table' ),