Changeset 38710

Timestamp:

10/03/2016 06:12:57 PM (8 years ago)

Author:

obenland

Message:

Themes: Account for uppercase chars when managing themes.

Fixes a bug where the UI wasn't updated after deleting/updating a theme.

Also introduces unit tests for theme management ajax handlers. For now they're
focused on wp_ajax_update_theme() but they can include tests for other
handlers as well.

Props chrisjean for initial patch.
Fixes #37924.

Location:

trunk

Files:

• src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)
• tests/phpunit/data/themedir1/camelCase (added)
• tests/phpunit/data/themedir1/camelCase/index.php (added)
• tests/phpunit/data/themedir1/camelCase/style.css (added)
• tests/phpunit/tests/ajax/ManageThemes.php (added)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -3406 +3406 @@
     }
 
-    $stylesheet = sanitize_key( wp_unslash( $_POST['slug'] ) );
+    $stylesheet = preg_replace( '/[^A-z0-9_\-]/', '', wp_unslash( $_POST['slug'] ) );
     $status     = array(
         'update'     => 'theme',
@@ -3491 +3491 @@
     }
 
-    $stylesheet = sanitize_key( wp_unslash( $_POST['slug'] ) );
+    $stylesheet = preg_replace( '/[^A-z0-9_\-]/', '', wp_unslash( $_POST['slug'] ) );
     $status     = array(
         'delete' => 'theme',