Changeset 38739

Timestamp:

10/06/2016 03:51:53 PM (8 years ago)

Author:

helen

Message:

Login: Don't rely on wp_is_mobile() for functionality.

Making behavior changes based on some broad definition of what mobile is rarely, if ever, makes sense. Each bit of functionality should be more clearly targeted, whether that's for screen size, performance, or some kind of touch capability.

props akibjorklund.
see #33704.

Location:

trunk/src

Files:

• wp-admin/css/login.css (modified) (2 diffs)
• wp-login.php (modified) (3 diffs)

trunk/src/wp-admin/css/login.css

@@ -217 +217 @@
 }
 
-.mobile #login {
-    padding: 20px 0;
-}
-
-.mobile #login form {
-    margin-left: 0;
-}
-
-.mobile #login #nav,
-.mobile #login #backtoblog {
-    margin-left: 8px;
-}
-
 body.interim-login {
     height: auto;
@@ -254 +241 @@
 @-ms-viewport {
     width: device-width;
+}
+
+@media screen and ( max-height: 550px ) {
+    #login {
+        padding: 20px 0;
+    }
 }
 

trunk/src/wp-login.php

@@ -37 +37 @@
     add_action( 'login_head', 'wp_no_robots' );
 
-    if ( wp_is_mobile() )
-        add_action( 'login_head', 'wp_login_viewport_meta' );
+    add_action( 'login_head', 'wp_login_viewport_meta' );
 
     if ( empty($wp_error) )
@@ -125 +124 @@
 
     $classes = array( 'login-action-' . $action, 'wp-core-ui' );
-    if ( wp_is_mobile() )
-        $classes[] = 'mobile';
     if ( is_rtl() )
         $classes[] = 'rtl';
@@ -261 +258 @@
  */
 function wp_shake_js() {
-    if ( wp_is_mobile() )
-        return;
 ?>
 <script type="text/javascript">