Changeset 38751

Timestamp:

10/07/2016 07:43:57 PM (8 years ago)

Author:

jorbin

Message:

Make sure rewrite rules are not written until wp_loaded has fired

If a plugin attempts to change the rewrite rules to early, other plugins may have their rules inadvertently discarded. Additionally, some function such as url_to_post_id cause a rewrite rule lookup that could cause this accidental flushing. This forces the flushing to only occur once wp_loaded has been fired.

Fixes #37892.
Props Chouby.

File:

• trunk/src/wp-includes/class-wp-rewrite.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-rewrite.php

@@ -1476 +1476 @@
             $this->matches = 'matches';
             $this->rewrite_rules();
+            if ( ! did_action( 'wp_loaded' ) ) {
+                add_action( 'wp_loaded', array( $this, 'flush_rules' ) );
+                return $this->rules;
+            }
             update_option('rewrite_rules', $this->rules);
         }