Changeset 38754

Timestamp:

10/07/2016 08:55:25 PM (8 years ago)

Author:

ocean90

Message:

Menus: Hide controls in the search tab if no items are found.

Props sayedwp, afercia, tywayne, abrightclearweb.
Fixes #35576.

Location:

trunk/src/wp-admin

Files:

• css/nav-menus.css (modified) (1 diff)
• includes/nav-menu.php (modified) (2 diffs)
• js/nav-menu.js (modified) (4 diffs)

trunk/src/wp-admin/css/nav-menus.css

@@ -26 +26 @@
 #nav-menu-meta .button-controls {
     margin-bottom: 0;
+}
+
+.has-no-menu-item .button-controls {
+    display: none;
 }
 

trunk/src/wp-admin/includes/nav-menu.php

@@ -572 +572 @@
                         remove_query_arg( $removed_args )
                     ));
-                ?>#posttype-<?php echo $post_type_name; ?>" class="select-all"><?php _e('Select All'); ?></a>
+                ?>#posttype-<?php echo $post_type_name; ?>" class="select-all aria-button-if-js"><?php _e( 'Select All' ); ?></a>
             </span>
 
@@ -770 +770 @@
                         remove_query_arg($removed_args)
                     ));
-                ?>#taxonomy-<?php echo $taxonomy_name; ?>" class="select-all"><?php _e('Select All'); ?></a>
+                ?>#taxonomy-<?php echo $taxonomy_name; ?>" class="select-all aria-button-if-js"><?php _e( 'Select All' ); ?></a>
             </span>
 

trunk/src/wp-admin/js/nav-menu.js

@@ -1061 +1061 @@
                     $('.quick-search', wrapper).focus();
 
+                    // Hide controls in the search tab if no items found.
+                    if ( ! wrapper.find( '.tabs-panel-active .menu-item-title' ).length ) {
+                        wrapper.addClass( 'has-no-menu-item' );
+                    } else {
+                        wrapper.removeClass( 'has-no-menu-item' );
+                    }
+
                     e.preventDefault();
                 } else if ( target.hasClass('select-all') ) {
@@ -1193 +1200 @@
             pattern = /menu-item[(\[^]\]*/,
             $items = $('<div>').html(resp).find('li'),
+            wrapper = panel.closest( '.accordion-section-content' ),
             $item;
 
@@ -1198 +1206 @@
                 $('.categorychecklist', panel).html( '<li><p>' + navMenuL10n.noResultsFound + '</p></li>' );
                 $( '.spinner', panel ).removeClass( 'is-active' );
+                wrapper.addClass( 'has-no-menu-item' );
                 return;
             }
@@ -1225 +1234 @@
             $('.categorychecklist', panel).html( $items );
             $( '.spinner', panel ).removeClass( 'is-active' );
+            wrapper.removeClass( 'has-no-menu-item' );
         },