Changeset 38762 for trunk/tests/phpunit/tests/file.php

Timestamp:

10/09/2016 01:11:14 AM (10 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Begin eliminating unnecessary randomness in tests.

Although unlikely, clashes in randomly generated strings could cause unexpected failures. In addition, most randomness is entirely unnecessary, is bad practice, and increases test time (however small it may be).

See #37371

File:

• trunk/tests/phpunit/tests/file.php (modified) (6 diffs)

trunk/tests/phpunit/tests/file.php

@@ -85 +85 @@
         function test_unique_filename_is_valid() {
                 // make sure it produces a valid, writable, unique filename
-                $filename = wp_unique_filename( $this->dir, rand_str() . '.txt' );
+                $filename = wp_unique_filename( $this->dir, __FUNCTION__ . '.txt' );
 
                 $this->assertTrue( $this->is_unique_writable_file($this->dir, $filename) );
@@ -94 +94 @@
         function test_unique_filename_is_unique() {
                 // make sure it produces two unique filenames
-                $name = rand_str();
+                $name = __FUNCTION__;
 
                 $filename1 = wp_unique_filename( $this->dir, $name . '.txt' );
@@ -109 +109 @@
 
         function test_unique_filename_is_sanitized() {
-                $name = rand_str();
+                $name = __FUNCTION__;
                 $filename = wp_unique_filename( $this->dir, $name . $this->badchars .  '.txt' );
 
@@ -121 +121 @@
 
         function test_unique_filename_with_slashes() {
-                $name = rand_str();
+                $name = __FUNCTION__;
                 // "foo/foo.txt"
                 $filename = wp_unique_filename( $this->dir, $name . '/' . $name .  '.txt' );
@@ -134 +134 @@
 
         function test_unique_filename_multiple_ext() {
-                $name = rand_str();
+                $name = __FUNCTION__;
                 $filename = wp_unique_filename( $this->dir, $name . '.php.txt' );
 
@@ -146 +146 @@
 
         function test_unique_filename_no_ext() {
-                $name = rand_str();
+                $name = __FUNCTION__;
                 $filename = wp_unique_filename( $this->dir, $name );