WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
10/09/2016 01:11:14 AM (10 years ago)
Author:
johnbillion
Message:

Build/Test Tools: Begin eliminating unnecessary randomness in tests.

Although unlikely, clashes in randomly generated strings could cause unexpected failures. In addition, most randomness is entirely unnecessary, is bad practice, and increases test time (however small it may be).

See #37371

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/hooks/has_filters.php

    r38571 r38762  
    1111        $callback = '__return_null';
    1212        $hook = new WP_Hook();
    13         $tag = rand_str();
     13        $tag = __FUNCTION__;
    1414        $priority = rand( 1, 100 );
    1515        $accepted_args = rand( 1, 100 );
    … …  
    2828        $callback = '__return_null';
    2929        $hook = new WP_Hook();
    30         $tag = rand_str();
     30        $tag = __FUNCTION__;
    3131        $priority = rand( 1, 100 );
    3232        $accepted_args = rand( 1, 100 );
    … …  
    4040        $callback = '__return_null';
    4141        $hook = new WP_Hook();
    42         $tag = rand_str();
     42        $tag = __FUNCTION__;
    4343        $priority = rand( 1, 100 );
    4444        $accepted_args = rand( 1, 100 );
Note: See TracChangeset for help on using the changeset viewer.