Changeset 38762 for trunk/tests/phpunit/tests/option/multisite.php

Timestamp:

10/09/2016 01:11:14 AM (10 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Begin eliminating unnecessary randomness in tests.

Although unlikely, clashes in randomly generated strings could cause unexpected failures. In addition, most randomness is entirely unnecessary, is bad practice, and increases test time (however small it may be).

See #37371

File:

• trunk/tests/phpunit/tests/option/multisite.php (modified) (3 diffs)

trunk/tests/phpunit/tests/option/multisite.php

@@ -26 +26 @@
 
     function test_from_same_site() {
-        $key = rand_str();
-        $key2 = rand_str();
-        $value = rand_str();
-        $value2 = rand_str();
+        $key    = __FUNCTION__ . '_1';
+        $key2   = __FUNCTION__ . '_2';
+        $value  = __FUNCTION__ . '_val1';
+        $value2 = __FUNCTION__ . '_val2';
 
         $this->assertFalse( get_blog_option( 1, 'doesnotexist' ) );
@@ -63 +63 @@
 
     function test_from_same_site_with_null_blog_id() {
-        $key = rand_str();
-        $key2 = rand_str();
-        $value = rand_str();
-        $value2 = rand_str();
+        $key    = __FUNCTION__ . '_1';
+        $key2   = __FUNCTION__ . '_2';
+        $value  = __FUNCTION__ . '_val1';
+        $value2 = __FUNCTION__ . '_val2';
 
         $this->assertFalse( get_blog_option( null, 'doesnotexist' ) );
@@ -110 +110 @@
         $this->assertInternalType( 'integer', $blog_id );
 
-        $key = rand_str();
-        $key2 = rand_str();
-        $value = rand_str();
-        $value2 = rand_str();
+        $key    = __FUNCTION__ . '_key1';
+        $key2   = __FUNCTION__ . '_key2';
+        $value  = __FUNCTION__ . '_val1';
+        $value2 = __FUNCTION__ . '_val2';
 
         $this->assertFalse( get_blog_option( $blog_id, 'doesnotexist' ) );