Changeset 38788

Timestamp:

10/14/2016 01:32:29 PM (8 years ago)

Author:

swissspidy

Message:

Themes: Do not show an update button if there's no update package.

This updates the list view to match the existing behaviour in the single theme modal.

Props tristangemus for initial patch.
Fixes #37774.

Location:

trunk/src/wp-admin

Files:

• includes/theme.php (modified) (1 diff)
• themes.php (modified) (1 diff)

trunk/src/wp-admin/includes/theme.php

@@ -573 +573 @@
             'active'       => $slug === $current_theme,
             'hasUpdate'    => isset( $updates[ $slug ] ),
+            'hasPackage'   => isset( $updates[ $slug ] ) && ! empty( $updates[ $slug ][ 'package' ] ),
             'update'       => get_theme_update_available( $theme ),
             'actions'      => array(

trunk/src/wp-admin/themes.php

@@ -379 +379 @@
 
     <# if ( data.hasUpdate ) { #>
-        <div class="update-message notice inline notice-warning notice-alt"><p><?php _e( 'New version available. <button class="button-link" type="button">Update now</button>' ); ?></p></div>
+        <# if ( data.hasPackage ) { #>
+            <div class="update-message notice inline notice-warning notice-alt"><p><?php _e( 'New version available. <button class="button-link" type="button">Update now</button>' ); ?></p></div>
+        <# } else { #>
+            <div class="update-message notice inline notice-warning notice-alt"><p><?php _e( 'New version available.' ); ?></p></div>
+        <# } #>
     <# } #>