Changeset 38812 for trunk/tests/phpunit/tests/media.php

Timestamp:

10/19/2016 03:05:51 AM (3 years ago)

Author:

joemcgill

Message:

Media: Remove alt fallbacks to improve accessibility.

This removes the fallbacks in wp_get_attachment_image() and in
wp.media.string.props which attempt to generate an alt value
from the image caption or title if an alt attribute isn't explicitly
set.

This allows for image HTML to be generated that contains an empty alt
value, i.e., alt="" which is much preferable for screen readers than
reading redundant content in the case of a caption, or when reading the
image title, which is often generated from the filename and not helpful
as alt text.

Props odie2, joedolson, rianrietveld, afercia, iamjolly, joemcgill.
Fixes #34635.

File:

• trunk/tests/phpunit/tests/media.php (modified) (2 diffs)

trunk/tests/phpunit/tests/media.php

@@ -917 +917 @@
 
     /**
+     * Tests the default output of `wp_get_attachment_image()`.
+     * @ticket 34635
+     */
+    function test_wp_get_attachment_image_defaults() {
+        $image = image_downsize( self::$large_id, 'thumbnail' );
+        $expected = sprintf( '<img width="%1$d" height="%2$d" src="%3$s" class="attachment-thumbnail size-thumbnail" alt="" />', $image[1], $image[2], $image[0] );
+
+        $this->assertEquals( $expected, wp_get_attachment_image( self::$large_id ) );
+    }
+
+    /**
+     * Test that `wp_get_attachment_image()` returns a proper alt value.
+     * @ticket 34635
+     */
+    function test_wp_get_attachment_image_with_alt() {
+        // Add test alt metadata.
+        update_post_meta( self::$large_id, '_wp_attachment_image_alt', 'Some very clever alt text', true );
+
+        $image = image_downsize( self::$large_id, 'thumbnail' );
+        $expected = sprintf( '<img width="%1$d" height="%2$d" src="%3$s" class="attachment-thumbnail size-thumbnail" alt="Some very clever alt text" />', $image[1], $image[2], $image[0] );
+
+        $this->assertEquals( $expected, wp_get_attachment_image( self::$large_id ) );
+
+        // Cleanup.
+        update_post_meta( self::$large_id, '_wp_attachment_image_alt', '', true );
+    }
+
+    /**
      * @ticket 33878
      */
@@ -1809 +1837 @@
 
         $expected = '<img width="999" height="999" src="http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $year . '/' . $month . '/test-image-testsize-999x999.png"' .
-            ' class="attachment-testsize size-testsize" alt="test-image-large.png"' .
+            ' class="attachment-testsize size-testsize" alt=""' .
             ' srcset="http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $year . '/' . $month . '/test-image-testsize-999x999.png 999w,' .
                 ' http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $year . '/' . $month . '/test-image-large-150x150.png 150w"' .