Changeset 38844 for trunk/tests/phpunit/tests/query/search.php

Timestamp:

10/20/2016 06:41:22 PM (9 years ago)

Author:

boonebgorges

Message:

Query: Allow the prefix used for search term exclusion to be filtered.

[38792] allowed WP_Query's hyphen-as-exclusion-prefix feature to be
disabled via filter. A more general solution is to allow the prefix to
be filtered; returning an empty value from a filter callback works to
disable the feature.

Props dlh.
Fixes #38099.

File:

• trunk/tests/phpunit/tests/query/search.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/search.php

@@ -63 +63 @@
      * @ticket 38099
      */
-    function test_filter_wp_query_use_hyphen_for_exclusion() {
+    function test_disable_search_exclusion_prefix() {
         $title = '-HYPHENATION_TEST';
 
@@ -75 +75 @@
 
         // After we disable the feature using the filter, we should get the result
-        add_filter( 'wp_query_use_hyphen_for_exclusion', '__return_false' );
+        add_filter( 'wp_query_search_exclusion_prefix', '__return_false' );
         $result = $this->get_search_results( $title );
         $post = array_pop( $result );
         $this->assertEquals( $post->ID, $post_id );
-        remove_filter( 'wp_query_use_hyphen_for_exclusion', '__return_false' );
+        remove_filter( 'wp_query_search_exclusion_prefix', '__return_false' );
+    }
+
+    /**
+     * @ticket 38099
+     */
+    function test_change_search_exclusion_prefix() {
+        $title = '#OCTOTHORPE_TEST';
+
+        // Create a post with a title that starts with a non-hyphen prefix.
+        $post_id = self::factory()->post->create( array(
+            'post_content' => $title, 'post_type' => $this->post_type
+        ) );
+
+        // By default, we should get the result.
+        $result = $this->get_search_results( $title );
+        $post = array_pop( $result );
+        $this->assertEquals( $post->ID, $post_id );
+
+        // After we change the prefix, the result should be excluded.
+        add_filter( 'wp_query_search_exclusion_prefix', array( $this, 'filter_search_exclusion_prefix_octothorpe' ) );
+        $found = $this->get_search_results( $title );
+        remove_filter( 'wp_query_search_exclusion_prefix', array( $this, 'filter_search_exclusion_prefix_octothorpe' ) );
+        $this->assertEquals( array(), $found );
+    }
+
+    function filter_search_exclusion_prefix_octothorpe() {
+        return '#';
     }