Changeset 38849 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

10/21/2016 02:53:19 AM (10 years ago)

Author:

jorbin

Message:

Cache API: introduce wp_cache_get_last_changed to improve DRY

One thing fairly common to the cache groups is a block of code to look to see when the cache was last changed, and if there isn't one, to set it for the current microtime(). It appears in 8 different places in core. This adds a new helper wp_cache_get_last_changed to DRY things up a bit.

Since wp-includes/cache.php isn't guaranteed to be loaded, this new function is in wp-includes/functions.php

Props spacedmonkey, desrosj.
Fixes #37464.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -394 +394 @@
                 // $args can include anything. Only use the args defined in the query_var_defaults to compute the key.
                 $key = md5( serialize( wp_array_slice_assoc( $this->query_vars, array_keys( $this->query_var_defaults ) ) ) );
-                $last_changed = wp_cache_get( 'last_changed', 'comment' );
-                if ( ! $last_changed ) {
-                        $last_changed = microtime();
-                        wp_cache_set( 'last_changed', $last_changed, 'comment' );
-                }
+                $last_changed = wp_cache_get_last_changed( 'comment' );
+
 
                 $cache_key   = "get_comments:$key:$last_changed";
@@ -973 +970 @@
 
                 $key = md5( serialize( wp_array_slice_assoc( $this->query_vars, array_keys( $this->query_var_defaults ) ) ) );
-                $last_changed = wp_cache_get( 'last_changed', 'comment' );
-                if ( ! $last_changed ) {
-                        $last_changed = microtime();
-                        wp_cache_set( 'last_changed', $last_changed, 'comment' );
-                }
+                $last_changed = wp_cache_get_last_changed( 'comment' );
 
                 // Fetch an entire level of the descendant tree at a time.