Changeset 38849 for trunk/src/wp-includes/post.php

Timestamp:

10/21/2016 02:53:19 AM (8 years ago)

Author:

jorbin

Message:

Cache API: introduce wp_cache_get_last_changed to improve DRY

One thing fairly common to the cache groups is a block of code to look to see when the cache was last changed, and if there isn't one, to set it for the current microtime(). It appears in 8 different places in core. This adds a new helper wp_cache_get_last_changed to DRY things up a bit.

Since wp-includes/cache.php isn't guaranteed to be loaded, this new function is in wp-includes/functions.php

Props spacedmonkey, desrosj.
Fixes #37464.

File:

• trunk/src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -4195 +4195 @@
     global $wpdb;
 
-    $last_changed = wp_cache_get( 'last_changed', 'posts' );
-    if ( false === $last_changed ) {
-        $last_changed = microtime();
-        wp_cache_set( 'last_changed', $last_changed, 'posts' );
-    }
+    $last_changed = wp_cache_get_last_changed( 'posts' );
 
     $hash = md5( $page_path . serialize( $post_type ) );
@@ -4541 +4537 @@
     // $args can be whatever, only use the args defined in defaults to compute the key.
     $key = md5( serialize( wp_array_slice_assoc( $r, array_keys( $defaults ) ) ) );
-    $last_changed = wp_cache_get( 'last_changed', 'posts' );
-    if ( ! $last_changed ) {
-        $last_changed = microtime();
-        wp_cache_set( 'last_changed', $last_changed, 'posts' );
-    }
+    $last_changed = wp_cache_get_last_changed( 'posts' );
 
     $cache_key = "get_pages:$key:$last_changed";