Changeset 38852 for trunk/src/wp-includes/post.php

Timestamp:

10/21/2016 05:59:34 AM (9 years ago)

Author:

pento

Message:

Pings: Allow ping functions to accept WP_Post objects as well as post IDs.

This removes the use of several global $wpdb instances, as well as bringing the ping functions into line with other post-related functions, which will accept a post ID or WP_Post object.

Props dshanke.
Fixes #38202.

File:

• trunk/src/wp-includes/post.php (modified) (4 diffs)

trunk/src/wp-includes/post.php

@@ -3992 +3992 @@
  *
  * @since 1.5.0
+ * @since 4.7.0 $post_id can be a WP_Post object.
+ * @since 4.7.0 $uri can be an array of URIs.
  *
  * @global wpdb $wpdb WordPress database abstraction object.
  *
- * @param int    $post_id Post ID.
- * @param string $uri     Ping URI.
+ * @param int|WP_Post  $post_id Post object or ID.
+ * @param string|array $uri     Ping URI or array of URIs.
  * @return int|false How many rows were updated.
  */
 function add_ping( $post_id, $uri ) {
     global $wpdb;
-    $pung = $wpdb->get_var( $wpdb->prepare( "SELECT pinged FROM $wpdb->posts WHERE ID = %d", $post_id ));
-    $pung = trim($pung);
-    $pung = preg_split('/\s/', $pung);
-    $pung[] = $uri;
+
+    $post = get_post( $post_id );
+    if ( ! $post ) {
+        return false;
+    }
+
+    $pung = trim( $post->pinged );
+    $pung = preg_split( '/\s/', $pung );
+
+    if ( is_array( $uri ) ) {
+        $pung = array_merge( $pung, $uri );
+    }
+    else {
+        $pung[] = $uri;
+    }
     $new = implode("\n", $pung);
 
@@ -4016 +4029 @@
     $new = apply_filters( 'add_ping', $new );
 
-    // expected_slashed ($new).
-    $new = wp_unslash($new);
-    return $wpdb->update( $wpdb->posts, array( 'pinged' => $new ), array( 'ID' => $post_id ) );
+    $return = $wpdb->update( $wpdb->posts, array( 'pinged' => $new ), array( 'ID' => $post->ID ) );
+    clean_post_cache( $post->ID );
+    return $return;
 }
 
@@ -4060 +4073 @@
  * @since 1.5.0
  *
- * @global wpdb $wpdb WordPress database abstraction object.
- *
- * @param int $post_id Post ID.
+ * @since 4.7.0 $post_id can be a WP_Post object.
+ *
+ * @param int|WP_Post $post_id Post ID or object.
  * @return array
  */
 function get_pung( $post_id ) {
-    global $wpdb;
-    $pung = $wpdb->get_var( $wpdb->prepare( "SELECT pinged FROM $wpdb->posts WHERE ID = %d", $post_id ));
-    $pung = trim($pung);
-    $pung = preg_split('/\s/', $pung);
+    $post = get_post( $post_id );
+    if ( ! $post ) {
+        return false;
+    }
+
+    $pung = trim( $post->pinged );
+    $pung = preg_split( '/\s/', $pung );
 
     /**
@@ -4085 +4101 @@
  *
  * @since 1.5.0
- *
- * @global wpdb $wpdb WordPress database abstraction object.
- *
- * @param int $post_id Post ID
+ * @since 4.7.0 $post_id can be a WP_Post object.
+ *
+ * @param int|WP_Post $post_id Post Object or ID
  * @return array
  */
 function get_to_ping( $post_id ) {
-    global $wpdb;
-    $to_ping = $wpdb->get_var( $wpdb->prepare( "SELECT to_ping FROM $wpdb->posts WHERE ID = %d", $post_id ));
-    $to_ping = sanitize_trackback_urls( $to_ping );
+    $post = get_post( $post_id );
+
+    if ( ! $post ) {
+        return false;
+    }
+
+    $to_ping = sanitize_trackback_urls( $post->to_ping );
     $to_ping = preg_split('/\s/', $to_ping, -1, PREG_SPLIT_NO_EMPTY);