Changeset 38855

Timestamp:

10/21/2016 10:35:51 AM (8 years ago)

Author:

swissspidy

Message:

Themes: After [38788], further improve the update button when there's no update package.

Prevents running shiny install when no package exists.

Fixes #37774.

Location:

trunk/src/wp-admin

Files:

• js/theme.js (modified) (1 diff)
• themes.php (modified) (1 diff)

trunk/src/wp-admin/js/theme.js

@@ -611 +611 @@
     updateTheme: function( event ) {
         var _this = this;
+
+        if ( ! this.model.get( 'hasPackage' ) ) {
+            return;
+        }
+
         event.preventDefault();
 

trunk/src/wp-admin/themes.php

@@ -253 +253 @@
     <?php if ( $theme['hasUpdate'] ) : ?>
         <div class="update-message notice inline notice-warning notice-alt">
+        <?php if ( $theme['hasPackage'] ) : ?>
             <p><?php _e( 'New version available. <button class="button-link" type="button">Update now</button>' ); ?></p>
+        <?php else : ?>
+            <p><?php _e( 'New version available.' ); ?></p>
+        <?php endif; ?>
         </div>
     <?php endif; ?>