Changeset 38868 for trunk/src/wp-content/themes/twentyseventeen/components/header/header-image.php

Timestamp:

10/21/2016 10:14:26 PM (9 years ago)

Author:

davidakennedy

Message:

Twenty Seventeen: Display featured image on static front page

This improves UX, since an image added will be displayed on front end as opposed to not at all. This fix added the front page's featured image above the front page content, similar to how it's handled in the other panels. Also it removed code that was setting the front page's featured image as a fallback to the custom header, and updated the conditions that add the has-header-image to remove reference to the front page's featured image.

Props laurelfulford.

Fixes #38402.

File:

• trunk/src/wp-content/themes/twentyseventeen/components/header/header-image.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/components/header/header-image.php

@@ -20 +20 @@
         <?php get_template_part( 'components/header/site', 'branding' ); ?>
 
-    <?php elseif ( twentyseventeen_is_frontpage() && has_post_thumbnail() ) :
-        // If not, fall back to front page's featured image, only on the front page.
-        $post_thumbnail_id = get_post_thumbnail_id( $post->ID );
-        $thumbnail_attributes = wp_get_attachment_image_src( $post_thumbnail_id, 'twentyseventeen-featured-image' );
-        ?>
-
-        <div class="custom-header-image" style="background-image: url(<?php echo esc_url( $thumbnail_attributes[0] ); ?>)"></div>
-        <?php get_template_part( 'components/header/site', 'branding' ); ?>
-
     <?php else : ?>
         <?php // Otherwise, show a blank header. ?>