Changeset 38881 for trunk/src/wp-includes/customize/class-wp-customize-header-image-control.php

Timestamp:

10/23/2016 07:56:43 PM (7 years ago)

Author:

afercia

Message:

Customize: Keep previously uploaded header images in place.

On the Header Image section, the previously uploaded images disappeared off-screen
when using the keyboard to navigate and the remove "X" button got keyboard focus.
Changing the off-screen CSS technique used for the "X" buttons fixes it.

• improves the focus style on the previously uploaded and suggested images
• removes a tabindex="0" attribute from the current header image

Fixes #38156.

File:

• trunk/src/wp-includes/customize/class-wp-customize-header-image-control.php (modified) (3 diffs)

trunk/src/wp-includes/customize/class-wp-customize-header-image-control.php

@@ -103 +103 @@
             <# } else { #>
 
-            <# if (data.type === 'uploaded') { #>
-                <button type="button" class="dashicons dashicons-no close"><span class="screen-reader-text"><?php _e( 'Remove image' ); ?></span></button>
-            <# } #>
-
             <button type="button" class="choice thumbnail"
                 data-customize-image-value="{{{data.header.url}}}"
@@ -113 +109 @@
                 <img src="{{{data.header.thumbnail_url}}}" alt="{{{data.header.alt_text || data.header.description}}}">
             </button>
+
+            <# if ( data.type === 'uploaded' ) { #>
+                <button type="button" class="dashicons dashicons-no close"><span class="screen-reader-text"><?php _e( 'Remove image' ); ?></span></button>
+            <# } #>
 
             <# } #>
@@ -132 +132 @@
                 <# } else { #>
 
-            <img src="{{{data.header.thumbnail_url}}}" alt="{{{data.header.alt_text || data.header.description}}}" tabindex="0"/>
+            <img src="{{{data.header.thumbnail_url}}}" alt="{{{data.header.alt_text || data.header.description}}}" />
 
                 <# } #>