Changeset 38883

Timestamp:

10/24/2016 04:44:07 AM (8 years ago)

Author:

pento

Message:

General: Check to see that the PHP-XML module is enabled before using XML functions.

There are a handful of places where we don't check that the XML functions exist before we use them. Ubuntu's PHP 7 packages don't include PHP-XML by default, increasing the chance of this causing issues.

Props kraftbj, markoheijnen.
Fixes #37122.

Location:

trunk/src

Files:

• wp-admin/link-parse-opml.php (modified) (1 diff)
• wp-includes/IXR/class-IXR-message.php (modified) (1 diff)
• wp-includes/atomlib.php (modified) (1 diff)
• wp-includes/feed.php (modified) (1 diff)
• wp-includes/rss.php (modified) (1 diff)

trunk/src/wp-admin/link-parse-opml.php

@@ -73 +73 @@
 
 // Create an XML parser
+if ( ! function_exists( 'xml_parser_create' ) ) {
+    trigger_error( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
+    wp_die( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
+}
+
 $xml_parser = xml_parser_create();
 

trunk/src/wp-includes/IXR/class-IXR-message.php

@@ -45 +45 @@
     function parse()
     {
+        if ( ! function_exists( 'xml_parser_create' ) ) {
+            trigger_error( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML" ) );
+            return false;
+        }
+
         // first remove the XML declaration
         // merged from WP #10698 - this method avoids the RAM usage of preg_replace on very large messages

trunk/src/wp-includes/atomlib.php

@@ -121 +121 @@
 
         array_unshift($this->ns_contexts, array());
+
+        if ( ! function_exists( 'xml_parser_create_ns' ) ) {
+            trigger_error( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
+            return false;
+        }
 
         $parser = xml_parser_create_ns();

trunk/src/wp-includes/feed.php

@@ -539 +539 @@
     }
 
+    if ( ! function_exists( 'xml_parser_create' ) ) {
+        trigger_error( __( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." ) );
+
+        return array( 'html', "<![CDATA[$data]]>" );
+    }
+
     $parser = xml_parser_create();
     xml_parse($parser, '<div>' . $data . '</div>', true);

trunk/src/wp-includes/rss.php

@@ -61 +61 @@
     function __construct( $source ) {
 
-        # if PHP xml isn't compiled in, die
+        # Check if PHP xml isn't compiled
         #
-        if ( !function_exists('xml_parser_create') )
-            trigger_error( "Failed to load PHP's XML Extension. https://secure.php.net/manual/en/ref.xml.php" );
-
-        $parser = @xml_parser_create();
-
-        if ( !is_resource($parser) )
-            trigger_error( "Failed to create an instance of PHP's XML parser. https://secure.php.net/manual/en/ref.xml.php");
+        if ( ! function_exists('xml_parser_create') ) {
+            return trigger_error( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." );
+        }
+
+        $parser = xml_parser_create();
 
         $this->parser = $parser;