Changeset 38886

Timestamp:

10/24/2016 05:58:18 PM (10 years ago)

Author:

davidakennedy

Message:

Twenty Seventeen: Fix smooth scrolling skip link

The link was scrolling too far. The main problem was that the menuTop variable lost it's initial definition of 0, so all future subtractions were failing.

Props tywayne.

Fixes #38448.

File:

• trunk/src/wp-content/themes/twentyseventeen/assets/js/global.js (modified) (2 diffs)

trunk/src/wp-content/themes/twentyseventeen/assets/js/global.js

@@ -24 +24 @@
                         navIsNotTooTall,
                         headerOffset,
-                        menuTop,
+                        menuTop = 0,
                         resizeTimer;
 
@@ -150 +150 @@
                          */
                         if ( $( 'body' ).hasClass( 'admin-bar' ) ) {
-                                menuTop = -32;
+                                menuTop -= 32;
                         }
                         if ( $( 'body' ).hasClass( 'blog' ) ) {