Context Navigation

← Previous Change
Next Change →

general-template.php

Timestamp:

10/25/2016 04:46:36 AM (10 years ago)

Author:

westonruter

Message:

Customize: Prevent absent site icon link from outputting an empty string as href in customizer; use /favicon.ico as fallback.

An empty string causes some browsers to use the current URL as the href. When using history.replaceState() Chrome will re-fetch the favicon with each call, meaning that customize.php gets hit with wasted requests which tax the server.

Fixes #38377.

File:

: 1 edited

trunk/src/wp-includes/general-template.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/general-template.php

-              r38857
+              r38901
+        }
+        $meta_tags = array(
+                sprintf( '<link rel="icon" href="%s" sizes="32x32" />', esc_url( get_site_icon_url( 32 ) ) ),
+                sprintf( '<link rel="icon" href="%s" sizes="192x192" />', esc_url( get_site_icon_url( 192 ) ) ),
+                sprintf( '<link rel="apple-touch-icon-precomposed" href="%s" />', esc_url( get_site_icon_url( 180 ) ) ),
+                sprintf( '<meta name="msapplication-TileImage" content="%s" />', esc_url( get_site_icon_url( 270 ) ) ),
+        );
+        $meta_tags = array();
+        $icon_32 = get_site_icon_url( 32 );
+        if ( empty( $icon_32 ) && is_customize_preview() ) {
+                $icon_32 = '/favicon.ico'; // Serve default favicon URL in customizer so element can be updated for preview.
+        }
+        if ( $icon_32 ) {
+                $meta_tags[] = sprintf( '<link rel="icon" href="%s" sizes="32x32" />', esc_url( $icon_32 ) );
+        }
+        $icon_192 = get_site_icon_url( 192 );
+        if ( $icon_192 ) {
+                $meta_tags[] = sprintf( '<link rel="icon" href="%s" sizes="192x192" />', esc_url( $icon_192 ) );
+        }
+        $icon_180 = get_site_icon_url( 180 );
+        if ( $icon_180 ) {
+                $meta_tags[] = sprintf( '<link rel="apple-touch-icon-precomposed" href="%s" />', esc_url( $icon_180 ) );
+        }
+        $icon_270 = get_site_icon_url( 270 );
+        if ( $icon_270 ) {
+                $meta_tags[] = sprintf( '<meta name="msapplication-TileImage" content="%s" />', esc_url( $icon_270 ) );
+        }
         /**

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 38901 for trunk/src/wp-includes/general-template.php

Legend:

trunk/src/wp-includes/general-template.php

Download in other formats: