Changeset 38901 for trunk/tests/phpunit/tests/general/template.php

Timestamp:

10/25/2016 04:46:36 AM (9 years ago)

Author:

westonruter

Message:

Customize: Prevent absent site icon link from outputting an empty string as href in customizer; use /favicon.ico as fallback.

An empty string causes some browsers to use the current URL as the href. When using history.replaceState() Chrome will re-fetch the favicon with each call, meaning that customize.php gets hit with wasted requests which tax the server.

Fixes #38377.

File:

• trunk/tests/phpunit/tests/general/template.php (modified) (4 diffs)

trunk/tests/phpunit/tests/general/template.php

@@ -24 +24 @@
 
     function tearDown() {
+        global $wp_customize;
         $this->_remove_custom_logo();
+        $this->_remove_site_icon();
+        $wp_customize = null;
 
         parent::tearDown();
@@ -52 +55 @@
         $this->expectOutputString( $this->site_icon_url );
         site_icon_url();
-        $this->_remove_site_icon();
     }
 
@@ -118 +120 @@
         $this->expectOutputString( $output );
         wp_site_icon();
-
-        $this->_remove_site_icon();
     }
 
@@ -144 +144 @@
         wp_site_icon();
         remove_filter( 'site_icon_meta_tags', array( $this, '_custom_site_icon_meta_tag' ) );
-
-        $this->_remove_site_icon();
+    }
+
+    /**
+     * @group site_icon
+     * @ticket 38377
+     */
+    function test_customize_preview_wp_site_icon_empty() {
+        global $wp_customize;
+        wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+        require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
+        $wp_customize = new WP_Customize_Manager();
+        $wp_customize->register_controls();
+        $wp_customize->start_previewing_theme();
+
+        $this->expectOutputString( '<link rel="icon" href="/favicon.ico" sizes="32x32" />' . "\n" );
+        wp_site_icon();
+    }
+
+    /**
+     * @group site_icon
+     * @ticket 38377
+     */
+    function test_customize_preview_wp_site_icon_dirty() {
+        global $wp_customize;
+        wp_set_current_user( $this->factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+        require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
+        $wp_customize = new WP_Customize_Manager();
+        $wp_customize->register_controls();
+        $wp_customize->start_previewing_theme();
+
+        $attachment_id = $this->_insert_attachment();
+        $wp_customize->set_post_value( 'site_icon', $attachment_id );
+        $wp_customize->get_setting( 'site_icon' )->preview();
+        $output = array(
+            sprintf( '<link rel="icon" href="%s" sizes="32x32" />', esc_url( wp_get_attachment_image_url( $attachment_id, 32 ) ) ),
+            sprintf( '<link rel="icon" href="%s" sizes="192x192" />', esc_url( wp_get_attachment_image_url( $attachment_id, 192 ) ) ),
+            sprintf( '<link rel="apple-touch-icon-precomposed" href="%s" />', esc_url( wp_get_attachment_image_url( $attachment_id, 180 ) ) ),
+            sprintf( '<meta name="msapplication-TileImage" content="%s" />', esc_url( wp_get_attachment_image_url( $attachment_id, 270 ) ) ),
+            '',
+        );
+        $output = implode( "\n", $output );
+        $this->expectOutputString( $output );
+        wp_site_icon();
     }