Changeset 38912

Timestamp:

10/25/2016 05:28:40 PM (8 years ago)

Author:

afercia

Message:

Menus: Improve the HTML semantics of the "Menu Settings" section.

• removes the previous markup based on a definition list
• groups checkboxes in fieldset elements with a legend
• simplifies the CSS lowering selectors specificity

Props xavortm.

Fixes #38023.

Location:

trunk/src/wp-admin

Files:

• css/nav-menus.css (modified) (4 diffs)
• nav-menus.php (modified) (2 diffs)

trunk/src/wp-admin/css/nav-menus.css

@@ -110 +110 @@
 }
 
-.menu-settings dl {
+.menu-settings-group {
     margin: 0 0 10px;
     overflow: hidden;
-    padding-left: 18%;
-}
-
-.menu-settings dd {
+    padding-left: 20%;
+}
+
+.menu-settings-group:last-of-type {
+    margin-bottom: 0;
+}
+
+.menu-settings-input {
     float: left;
     margin: 0;
@@ -122 +126 @@
 }
 
-.menu-settings dt {
+.menu-settings-group-name {
     float: left;
     clear: both;
-    width: 21.951%;
+    width: 25%;
     padding: 3px 0 0;
-    margin-left: -21.951%;
+    margin-left: -25%; /* 20 container left padding x ( 100 container % width / 80 this % width ) */
 }
 
@@ -870 +874 @@
     }
 
-    .menu-settings dl {
+    .menu-settings-group {
         padding-left: 0;
     }
 
-    .menu-settings dd {
-        float: none;
-        width: 100%;
-        margin-bottom: 15px;
-    }
-
-    .menu-settings dt {
+    .menu-settings-group-name {
         float: none;
         width: auto;
@@ -887 +885 @@
     }
 
+    .menu-settings-input {
+        float: none;
+        margin-bottom: 15px;
+    }
+
+    .menu-edit .checkbox-input {
+        margin-top: 0;
+    }
+
     .manage-menus select {
         margin: 0.5em 0;

trunk/src/wp-admin/nav-menus.php

@@ -799 +799 @@
                                 } ?>
 
-                                <dl class="auto-add-pages">
-                                    <dt class="howto"><?php _e( 'Auto add pages' ); ?></dt>
-                                    <dd class="checkbox-input"><input type="checkbox"<?php checked( $auto_add ); ?> name="auto-add-pages" id="auto-add-pages" value="1" /> <label for="auto-add-pages"><?php printf( __('Automatically add new top-level pages to this menu' ), esc_url( admin_url( 'edit.php?post_type=page' ) ) ); ?></label></dd>
-                                </dl>
+                                <fieldset class="menu-settings-group auto-add-pages">
+                                    <legend class="menu-settings-group-name howto"><?php _e( 'Auto add pages' ); ?></legend>
+                                    <div class="menu-settings-input checkbox-input">
+                                        <input type="checkbox"<?php checked( $auto_add ); ?> name="auto-add-pages" id="auto-add-pages" value="1" /> <label for="auto-add-pages"><?php printf( __('Automatically add new top-level pages to this menu' ), esc_url( admin_url( 'edit.php?post_type=page' ) ) ); ?></label>
+                                    </div>
+                                </fieldset>
 
                                 <?php if ( current_theme_supports( 'menus' ) ) : ?>
 
-                                    <dl class="menu-theme-locations">
-                                        <dt class="howto"><?php _e( 'Theme locations' ); ?></dt>
+                                    <fieldset class="menu-settings-group menu-theme-locations">
+                                        <legend class="menu-settings-group-name howto"><?php _e( 'Theme locations' ); ?></legend>
                                         <?php foreach ( $locations as $location => $description ) : ?>
-                                        <dd class="checkbox-input">
+                                        <div class="menu-settings-input checkbox-input">
                                             <input type="checkbox"<?php checked( isset( $menu_locations[ $location ] ) && $menu_locations[ $location ] == $nav_menu_selected_id ); ?> name="menu-locations[<?php echo esc_attr( $location ); ?>]" id="locations-<?php echo esc_attr( $location ); ?>" value="<?php echo esc_attr( $nav_menu_selected_id ); ?>" />
                                             <label for="locations-<?php echo esc_attr( $location ); ?>"><?php echo $description; ?></label>
@@ -820 +822 @@
                                                 ?></span>
                                             <?php endif; ?>
-                                        </dd>
+                                        </div>
                                         <?php endforeach; ?>
-                                    </dl>
+                                    </fieldset>
 
                                 <?php endif; ?>