WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/25/2016 08:47:06 PM (5 years ago)
Author:
rachelbaker
Message:

Feeds: Always return a valid timestamp for the Last-Modified header of comment or post feeds.

Fixes bug where an invalid Last-Modified value would be returned in feed requests for sites that had 0 items to return. Comment or post feeds will now return the current timestamp as the Last-Modified header value. Example: a request for the comments feed for a site without any comments.

Replaced use of the local static variable $cache_lastcommentmodified to store the modified date in get_lastcommentmodified() with the Object Cache API. The get_lastcommentmodified() function returns early if there is a cached value and returns false if there where no comments found. Introduced _clear_modified_cache_on_transition_comment_status() to flush the lastcommentmodified cache key when a comment enters or leaves approval status. In get_lastpostmodified() return early if there is a cached value and return false if there are no posts found.

Props swissspidy, rachelbaker, dllh, leobaiano.
Fixes #38027.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/feed-rss2.php

    r37518 r38925  
    4343    <link><?php bloginfo_rss('url') ?></link>
    4444    <description><?php bloginfo_rss("description") ?></description>
    45     <lastBuildDate><?php echo mysql2date('D, d M Y H:i:s +0000', get_lastpostmodified('GMT'), false); ?></lastBuildDate>
     45    <lastBuildDate><?php
     46        $date = get_lastpostmodified( 'GMT' );
     47        echo $date ? mysql2date( 'D, d M Y H:i:s +0000', $date ) : date( 'D, d M Y H:i:s +0000' );
     48    ?></lastBuildDate>
    4649    <language><?php bloginfo_rss( 'language' ); ?></language>
    4750    <sy:updatePeriod><?php
Note: See TracChangeset for help on using the changeset viewer.